From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: add GPU max frequency control file
Date: Wed, 27 Jul 2011 11:53:08 -0700
Message-ID: <20110727115308.2c9d0a5a@jbarnes-desktop>
References: <1311789208-2494-1-git-send-email-jbarnes@virtuousgeek.org>
	<yunhb67lfpr.fsf@aiko.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com
	[67.222.38.55])
	by gabe.freedesktop.org (Postfix) with SMTP id 568F99EB20
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 27 Jul 2011 11:53:16 -0700 (PDT)
In-Reply-To: <yunhb67lfpr.fsf@aiko.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 27 Jul 2011 11:51:28 -0700
Keith Packard <keithp@keithp.com> wrote:

> On Wed, 27 Jul 2011 10:53:28 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> 
> > +	len = snprintf(buf, sizeof (buf),
> > +		       "freq: %d\n", dev_priv->max_delay * 50);
> 
> should probably be 'Max frequency' too?
> 
> > +
> > +	if (len > sizeof (buf))
> > +		len = sizeof (buf);
> > +
> > +	return simple_read_from_buffer(ubuf, max, ppos, buf, len);
> > +}
> > +
> > +static ssize_t
> > +i915_max_freq_write(struct file *filp,
> > +		  const char __user *ubuf,
> > +		  size_t cnt,
> > +		  loff_t *ppos)
> > +{
> > +	struct drm_device *dev = filp->private_data;
> > +	struct drm_i915_private *dev_priv = dev->dev_private;
> > +	char buf[20];
> > +	int val = 1;
> > +
> > +	if (cnt > 0) {
> > +		if (cnt > sizeof (buf) - 1)
> > +			return -EINVAL;
> > +
> > +		if (copy_from_user(buf, ubuf, cnt))
> > +			return -EFAULT;
> > +		buf[cnt] = 0;
> > +
> > +		val = simple_strtoul(buf, NULL, 0);
> > +	}
> > +
> > +	DRM_DEBUG_DRIVER("Manually setting freq to %d\n", val);
> 
> And 'max freq' here too.
> 
> Otherwise, this seems useful to me too.

Ok updated one just sent.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center