From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Michal Hocko <mhocko@suse.cz>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v4 00/10] Prevent LRU churning
Date: Wed, 27 Jul 2011 13:16:50 -0700 [thread overview]
Message-ID: <20110727131650.ad30a331.akpm@linux-foundation.org> (raw)
In-Reply-To: <cover.1309787991.git.minchan.kim@gmail.com>
On Mon, 4 Jul 2011 23:04:33 +0900
Minchan Kim <minchan.kim@gmail.com> wrote:
> Test result is following as.
>
> 1) Elapased time 10GB file decompressed.
> Old inorder inorder + pagevec flush[10/10]
> 01:47:50.88 01:43:16.16 01:40:27.18
>
> 2) failure of inorder lru
> For test, it isolated 375756 pages. Only 45875 pages(12%) are put backed to
> out-of-order(ie, head of LRU) Others, 329963 pages(88%) are put backed to in-order
> (ie, position of old page in LRU).
I'm getting more and more worried about how complex MM is becoming and
this patchset doesn't take us in a helpful direction :(
But it's hard to argue with numbers like that. Please respin patches 6-10?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Michal Hocko <mhocko@suse.cz>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v4 00/10] Prevent LRU churning
Date: Wed, 27 Jul 2011 13:16:50 -0700 [thread overview]
Message-ID: <20110727131650.ad30a331.akpm@linux-foundation.org> (raw)
In-Reply-To: <cover.1309787991.git.minchan.kim@gmail.com>
On Mon, 4 Jul 2011 23:04:33 +0900
Minchan Kim <minchan.kim@gmail.com> wrote:
> Test result is following as.
>
> 1) Elapased time 10GB file decompressed.
> Old inorder inorder + pagevec flush[10/10]
> 01:47:50.88 01:43:16.16 01:40:27.18
>
> 2) failure of inorder lru
> For test, it isolated 375756 pages. Only 45875 pages(12%) are put backed to
> out-of-order(ie, head of LRU) Others, 329963 pages(88%) are put backed to in-order
> (ie, position of old page in LRU).
I'm getting more and more worried about how complex MM is becoming and
this patchset doesn't take us in a helpful direction :(
But it's hard to argue with numbers like that. Please respin patches 6-10?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-27 20:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 14:04 [PATCH v4 00/10] Prevent LRU churning Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 01/10] compaction: trivial clean up acct_isolated Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 02/10] Change isolate mode from #define to bitwise type Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 03/10] compaction: make isolate_lru_page with filter aware Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 04/10] zone_reclaim: " Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 05/10] migration: clean up unmap_and_move Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 06/10] migration: introudce migrate_ilru_pages Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-27 20:13 ` Andrew Morton
2011-07-27 20:13 ` Andrew Morton
2011-07-31 16:21 ` Minchan Kim
2011-07-31 16:21 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 07/10] compaction: make compaction use in-order putback Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 08/10] ilru: reduce zone->lru_lock Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-27 20:14 ` Andrew Morton
2011-07-27 20:14 ` Andrew Morton
2011-07-31 16:31 ` Minchan Kim
2011-07-31 16:31 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 09/10] add inorder-lru tracepoints for just measurement Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-04 14:04 ` [PATCH v4 10/10] compaction: add drain ilru of pagevec Minchan Kim
2011-07-04 14:04 ` Minchan Kim
2011-07-27 20:16 ` Andrew Morton [this message]
2011-07-27 20:16 ` [PATCH v4 00/10] Prevent LRU churning Andrew Morton
2011-07-29 8:23 ` Minchan Kim
2011-07-29 8:23 ` Minchan Kim
-- strict thread matches above, loose matches on Subject: below --
2011-06-30 14:55 Minchan Kim
2011-06-30 14:55 ` Minchan Kim
2011-06-30 15:02 ` Minchan Kim
2011-06-30 15:02 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727131650.ad30a331.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.