broken checkpatch signature checking

broken checkpatch signature checking

[Dave Jones]

The signature checking patches in commit 2011247550 have broken one use-case for me.
I pipe the git-commits mailing list to it and skim the summary once a day[*]

Because git indents its changelogs, every single commit is now warning
with this..

WARNING: Do not use whitespace before Signed-off-by:
#5252:
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>


	Dave


[*] It's too noisy to do anything useful with right now, which is
    why I'd like to filter out all the whitespace crap, but hopefully
    that'll happen eventually.

Re: broken checkpatch signature checking

[Joe Perches]

On Thu, 2011-07-28 at 00:33 -0400, Dave Jones wrote:
> The signature checking patches in commit 2011247550 have broken one use-case for me.
> I pipe the git-commits mailing list to it and skim the summary once a day[*]
> Because git indents its changelogs, every single commit is now warning
> with this..
> WARNING: Do not use whitespace before Signed-off-by:
> #5252:
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 	Dave
> [*] It's too noisy to do anything useful with right now, which is
>     why I'd like to filter out all the whitespace crap, but hopefully
>     that'll happen eventually.

Hey Dave.

Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?

I think that the general use case is OK.

I'm not sure that it's appropriate to use
checkpatch on git log output.

cheers, Joe

Re: broken checkpatch signature checking

[Dave Jones]

On Wed, Jul 27, 2011 at 09:41:42PM -0700, Joe Perches wrote:
 > On Thu, 2011-07-28 at 00:33 -0400, Dave Jones wrote:
 > > The signature checking patches in commit 2011247550 have broken one use-case for me.
 > > I pipe the git-commits mailing list to it and skim the summary once a day[*]
 > > Because git indents its changelogs, every single commit is now warning
 > > with this..
 > > WARNING: Do not use whitespace before Signed-off-by:
 > > #5252:
 > >     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
 > 
 > Hey Dave.
 > 
 > Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?

Ok, that works for me.  I guess I should add all the whitespace ignores while I'm at it.

thanks,

	Dave

Re: broken checkpatch signature checking

[Joe Perches]

On Thu, 2011-07-28 at 00:49 -0400, Dave Jones wrote:
> On Wed, Jul 27, 2011 at 09:41:42PM -0700, Joe Perches wrote:
>  > On Thu, 2011-07-28 at 00:33 -0400, Dave Jones wrote:
>  > > The signature checking patches in commit 2011247550 have broken one use-case for me.
>  > > I pipe the git-commits mailing list to it and skim the summary once a day[*]
>  > > Because git indents its changelogs, every single commit is now warning
>  > > with this..
>  > > WARNING: Do not use whitespace before Signed-off-by:
>  > Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?
> Ok, that works for me.  I guess I should add all the whitespace ignores while I'm at it.

or maybe add --ignore-all-space to git log