From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1QmSTz-00030A-5j
	for qemu-devel@nongnu.org; Thu, 28 Jul 2011 11:26:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1QmSTy-00017y-6u
	for qemu-devel@nongnu.org; Thu, 28 Jul 2011 11:26:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36231)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1QmSTx-00017s-TZ
	for qemu-devel@nongnu.org; Thu, 28 Jul 2011 11:26:42 -0400
Date: Thu, 28 Jul 2011 12:26:32 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20110728152632.GA19040@amt.cnet>
References: <20110728151216.GA18809@amt.cnet>
	<CAFEAcA96AWpq2w2c-3fMrqOwBMk2wikCFCYOPawi_RSZuMPF4g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA96AWpq2w2c-3fMrqOwBMk2wikCFCYOPawi_RSZuMPF4g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] net: fix default MAC assignment for
 hotplugged NICs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Thu, Jul 28, 2011 at 04:22:09PM +0100, Peter Maydell wrote:
> On 28 July 2011 16:12, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> >
> > The index for assignment of default MAC address is duplicated:
> > qemu_macaddr_default_if_unset has its own variable and net_init_nic uses
> > the nic table index.
> 
> Isn't this already fixed by commit 6eed18568d ?
> 
> -- PMM

Yes, thanks for pointing out.