Re: [lm-sensors] [PATCH] hwmon: (zl6100) Add new chip support

[Guenter Roeck <guenter.roeck@ericsson.com>]

On Wed, Jun 22, 2011 at 09:49:21AM +0800, b29983@freescale.com wrote:
> From: Tang Yuantian <B29983@freescale.com>
> 
> 	The ZL6100 is a digital power controller with Power Monitoring support.
> 	It provides an I2C/SMBus digital interface that enables the user to
> 	configure all aspects of the device operation as well as monitor the
> 	input and output parameters. It accepts most standard PMBus commands.
> 	Four parameters are output here which are Output Current, Output Voltage,
> 	Local Temperature and Remote Temperature.
> 
> 	This chip is currently used on some PowerPC platform.
> 
> Signed-off-by: Tang Yuantian <b29983@freescale.com>

Hi,

I finally got an eval board for the ZL6100 and was able to do some testing.

The key problem with the chip and the generic PMBus driver is reflected by the
	msleep(2);
in your driver. Problem here is that this adds a delay of up to 20ms to each
and every I2C read command, which is really not desirable. I found that udelay(500)
does the trick as well, but is not much better. I'll need to think about this
a bit.

Where do you have the 2ms value from ? I don't seem to be able to find it in the datasheet.
Also, the ZL6105 does not seem to have the timing problem.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors