All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, hostap@lists.shmoo.com
Subject: Re: mac80211 + hostapd: EAPOL frames rate selection
Date: Fri, 29 Jul 2011 20:37:54 +0300	[thread overview]
Message-ID: <20110729173754.GC3418@jm.kir.nu> (raw)
In-Reply-To: <CAGXE3d9gX0LQjHiYB6vpD8AvfdrwOr5DZs=sGxZzHYW5RSZHsQ@mail.gmail.com>

On Fri, Jul 29, 2011 at 11:14:20AM +0200, Helmut Schaa wrote:
> I just noticed that EAPOL frames generated by hostapd during the 4-way
> handshake are sent out by mac80211 using a rate as selected by the rc
> algorithm for data frames. In my case minstrel_ht selects a MCS rate for
> 11n clients which sometimes results in a 4-way handshake timeout under
> low signal conditions.

That sounds like an issue that should be fixed in the rate control
algorithm if it is indeed using unsuitable rate immediately after
association. Dropping data frames completely is not really a good thing
regardless of whether they are EAPOL packets or not..

> I haven't found anything in 802.11-2007 if EAPOL frames have to be sent
> at a low rate but I'd argue that it makes sense to send them at a basic
> rate just like it's done for management frames.

There is no such requirement in the standard and I don't see why basic
rates would necessarily be better for this use. Basic rate set is just a
common set of rates that can be used for broadcast/multicast since all
stations in the BSS are known to support them. The EAPOL frames here are
sent as unicast frames.

> We've got a nice little helper in mac80211 (rate_control_send_low) that
> allows the rc algorithm to check if a frame should be sent at a low rate.
> I thought I'd hook in there and just check skb->protocol to force EAPOL
> frames to the lowest rate. However, this didn't work out because in AP
> mode the EAPOL frames are injected through a monitor interface and as
> such skb->protocol is never initialized (ieee80211_monitor_start_xmit).

Some EAPOL frames can be quite large (e.g., EAP-TLS). Forcing those to
go out at 1 Mbps on a congested 2.4 GHz band channel sounds like a bad
idea in general if the stations would be able to use HT rates at the
time..

-- 
Jouni Malinen                                            PGP id EFC895FA

  parent reply	other threads:[~2011-07-29 17:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29  9:14 mac80211 + hostapd: EAPOL frames rate selection Helmut Schaa
2011-07-29 10:20 ` Mohammed Shafi
2011-07-29 15:17   ` Mohammed Shafi
2011-07-29 15:52     ` Andreas Hartmann
2011-07-29 17:37 ` Jouni Malinen [this message]
2011-07-29 17:55   ` Helmut Schaa
2011-07-29 18:05     ` Felix Fietkau
2012-12-17 17:26       ` Paul Stewart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110729173754.GC3418@jm.kir.nu \
    --to=j@w1.fi \
    --cc=helmut.schaa@googlemail.com \
    --cc=hostap@lists.shmoo.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.