From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6VFOCH9220857 for ; Sun, 31 Jul 2011 10:24:13 -0500 Received: from mail-pz0-f43.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 761F5F0DFEA for ; Sun, 31 Jul 2011 08:24:45 -0700 (PDT) Received: from mail-pz0-f43.google.com (mail-pz0-f43.google.com [209.85.210.43]) by cuda.sgi.com with ESMTP id FT4Hq08ntk6E7g4m for ; Sun, 31 Jul 2011 08:24:45 -0700 (PDT) Received: by pzk1 with SMTP id 1so7738243pzk.2 for ; Sun, 31 Jul 2011 08:24:11 -0700 (PDT) Date: Mon, 1 Aug 2011 00:24:01 +0900 From: Minchan Kim Subject: Re: [PATCH 7/8] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes Message-ID: <20110731152401.GE1735@barrios-desktop> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-8-git-send-email-mgorman@suse.de> <1311339228.27400.34.camel@twins> <20110722132319.GX5349@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110722132319.GX5349@suse.de> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mel Gorman Cc: Rik van Riel , Jan Kara , Peter Zijlstra , LKML , XFS , Christoph Hellwig , Linux-MM , Wu Fengguang , Johannes Weiner On Fri, Jul 22, 2011 at 02:23:19PM +0100, Mel Gorman wrote: > On Fri, Jul 22, 2011 at 02:53:48PM +0200, Peter Zijlstra wrote: > > On Thu, 2011-07-21 at 17:28 +0100, Mel Gorman wrote: > > > When direct reclaim encounters a dirty page, it gets recycled around > > > the LRU for another cycle. This patch marks the page PageReclaim > > > similar to deactivate_page() so that the page gets reclaimed almost > > > immediately after the page gets cleaned. This is to avoid reclaiming > > > clean pages that are younger than a dirty page encountered at the > > > end of the LRU that might have been something like a use-once page. > > > > > > > > @@ -834,7 +834,15 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > > */ > > > if (page_is_file_cache(page) && > > > (!current_is_kswapd() || priority >= DEF_PRIORITY - 2)) { > > > - inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > > + /* > > > + * Immediately reclaim when written back. > > > + * Similar in principal to deactivate_page() > > > + * except we already have the page isolated > > > + * and know it's dirty > > > + */ > > > + inc_zone_page_state(page, NR_VMSCAN_INVALIDATE); > > > + SetPageReclaim(page); > > > + > > > > I find the invalidate name somewhat confusing. It makes me think we'll > > drop the page without writeback, like invalidatepage(). > > I wasn't that happy with it either to be honest but didn't think of a > better one at the time. nr_reclaim_deferred? How about "NR_VMSCAN_IMMEDIATE_RECLAIM" like comment rotate_reclaimable_page? > > -- > Mel Gorman > SUSE Labs -- Kind regards, Minchan Kim _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752104Ab1GaPYQ (ORCPT ); Sun, 31 Jul 2011 11:24:16 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:42907 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772Ab1GaPYM (ORCPT ); Sun, 31 Jul 2011 11:24:12 -0400 Date: Mon, 1 Aug 2011 00:24:01 +0900 From: Minchan Kim To: Mel Gorman Cc: Peter Zijlstra , Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel Subject: Re: [PATCH 7/8] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes Message-ID: <20110731152401.GE1735@barrios-desktop> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-8-git-send-email-mgorman@suse.de> <1311339228.27400.34.camel@twins> <20110722132319.GX5349@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110722132319.GX5349@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2011 at 02:23:19PM +0100, Mel Gorman wrote: > On Fri, Jul 22, 2011 at 02:53:48PM +0200, Peter Zijlstra wrote: > > On Thu, 2011-07-21 at 17:28 +0100, Mel Gorman wrote: > > > When direct reclaim encounters a dirty page, it gets recycled around > > > the LRU for another cycle. This patch marks the page PageReclaim > > > similar to deactivate_page() so that the page gets reclaimed almost > > > immediately after the page gets cleaned. This is to avoid reclaiming > > > clean pages that are younger than a dirty page encountered at the > > > end of the LRU that might have been something like a use-once page. > > > > > > > > @@ -834,7 +834,15 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > > */ > > > if (page_is_file_cache(page) && > > > (!current_is_kswapd() || priority >= DEF_PRIORITY - 2)) { > > > - inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > > + /* > > > + * Immediately reclaim when written back. > > > + * Similar in principal to deactivate_page() > > > + * except we already have the page isolated > > > + * and know it's dirty > > > + */ > > > + inc_zone_page_state(page, NR_VMSCAN_INVALIDATE); > > > + SetPageReclaim(page); > > > + > > > > I find the invalidate name somewhat confusing. It makes me think we'll > > drop the page without writeback, like invalidatepage(). > > I wasn't that happy with it either to be honest but didn't think of a > better one at the time. nr_reclaim_deferred? How about "NR_VMSCAN_IMMEDIATE_RECLAIM" like comment rotate_reclaimable_page? > > -- > Mel Gorman > SUSE Labs -- Kind regards, Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 378E2900137 for ; Sun, 31 Jul 2011 11:24:14 -0400 (EDT) Received: by pzk33 with SMTP id 33so10316086pzk.36 for ; Sun, 31 Jul 2011 08:24:11 -0700 (PDT) Date: Mon, 1 Aug 2011 00:24:01 +0900 From: Minchan Kim Subject: Re: [PATCH 7/8] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes Message-ID: <20110731152401.GE1735@barrios-desktop> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-8-git-send-email-mgorman@suse.de> <1311339228.27400.34.camel@twins> <20110722132319.GX5349@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110722132319.GX5349@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Peter Zijlstra , Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Rik van Riel On Fri, Jul 22, 2011 at 02:23:19PM +0100, Mel Gorman wrote: > On Fri, Jul 22, 2011 at 02:53:48PM +0200, Peter Zijlstra wrote: > > On Thu, 2011-07-21 at 17:28 +0100, Mel Gorman wrote: > > > When direct reclaim encounters a dirty page, it gets recycled around > > > the LRU for another cycle. This patch marks the page PageReclaim > > > similar to deactivate_page() so that the page gets reclaimed almost > > > immediately after the page gets cleaned. This is to avoid reclaiming > > > clean pages that are younger than a dirty page encountered at the > > > end of the LRU that might have been something like a use-once page. > > > > > > > > @@ -834,7 +834,15 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > > */ > > > if (page_is_file_cache(page) && > > > (!current_is_kswapd() || priority >= DEF_PRIORITY - 2)) { > > > - inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > > + /* > > > + * Immediately reclaim when written back. > > > + * Similar in principal to deactivate_page() > > > + * except we already have the page isolated > > > + * and know it's dirty > > > + */ > > > + inc_zone_page_state(page, NR_VMSCAN_INVALIDATE); > > > + SetPageReclaim(page); > > > + > > > > I find the invalidate name somewhat confusing. It makes me think we'll > > drop the page without writeback, like invalidatepage(). > > I wasn't that happy with it either to be honest but didn't think of a > better one at the time. nr_reclaim_deferred? How about "NR_VMSCAN_IMMEDIATE_RECLAIM" like comment rotate_reclaimable_page? > > -- > Mel Gorman > SUSE Labs -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org