From: Ben Dooks <ben-i2c@fluff.org>
To: Paul Gortmaker <paul.gortmaker@gmail.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-i2c@vger.kernel.org, akpm <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
khali@linux-fr.org, ben-linux@fluff.org
Subject: Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h
Date: Sun, 31 Jul 2011 17:42:08 +0100 [thread overview]
Message-ID: <20110731164208.GP15795@trinity.fluff.org> (raw)
In-Reply-To: <CAP=VYLrtumuSM_ncO6sEr7=HciiKcOsB=yN4NZnAxesjSSOgMw@mail.gmail.com>
On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote:
> On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
> > include that file. This fixes build errors.
>
> Applied to module.h-split, thanks.
ok, so I don't need to apply this one?
Acked-by: Ben Dooks <ben-linux@fluff.org>
> P.
>
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> > drivers/i2c/busses/i2c-pxa-pci.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
> > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
> > @@ -3,6 +3,7 @@
> > * It does not support slave mode, the register slightly moved. This PCI
> > * device provides three bars, every contains a single I2C controller.
> > */
> > +#include <linux/module.h>
> > #include <linux/pci.h>
> > #include <linux/platform_device.h>
> > #include <linux/i2c/pxa-i2c.h>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-next" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-07-31 16:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 7:38 linux-next: Tree for July 29 Stephen Rothwell
2011-07-29 19:07 ` [PATCH -next] x86: files need export.h Randy Dunlap
2011-07-30 18:51 ` Paul Gortmaker
2011-07-29 19:43 ` [PATCH -next] regulator: aat2870 needs module.h Randy Dunlap
2011-07-30 1:04 ` [PATCH -next] x86: devicetree.h needs export.h Randy Dunlap
2011-07-30 19:00 ` Paul Gortmaker
2011-07-30 1:09 ` [PATCH -next] sfi: sfi_acpi.c needs sysfs.h Randy Dunlap
2011-07-30 19:05 ` Paul Gortmaker
2011-07-30 4:11 ` [PATCH -next] power: max8998_charger.c needs module.h Randy Dunlap
2011-08-19 17:02 ` Anton Vorontsov
2011-07-30 4:13 ` [PATCH -next] regulator: aat2870-regulator.c " Randy Dunlap
2011-08-01 0:15 ` Mark Brown
2011-08-01 0:33 ` Stephen Rothwell
2011-08-01 1:05 ` Stephen Rothwell
2011-08-01 9:25 ` Samuel Ortiz
2011-08-01 9:25 ` Samuel Ortiz
2011-08-01 18:09 ` Liam Girdwood
2011-08-03 10:28 ` Samuel Ortiz
2011-07-30 4:14 ` [PATCH -next] sound: rtctimer.c " Randy Dunlap
2011-07-30 6:04 ` Takashi Iwai
2011-07-30 4:14 ` [PATCH -next] i2c: i2c-pxa-pci.c " Randy Dunlap
[not found] ` <20110729211430.6c4830bd.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2011-07-30 19:09 ` Paul Gortmaker
2011-07-30 19:09 ` Paul Gortmaker
2011-07-31 16:42 ` Ben Dooks [this message]
[not found] ` <20110731164208.GP15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-07-31 19:41 ` Paul Gortmaker
2011-07-31 19:41 ` Paul Gortmaker
2011-07-30 4:14 ` [PATCH -next] input: mouse/hgpk.c " Randy Dunlap
2011-07-30 19:02 ` Dmitry Torokhov
2011-07-30 4:14 ` [PATCH -next] x86/platform: geode/alix.c " Randy Dunlap
2011-07-30 4:14 ` [PATCH -next] x86/platform: mrst/pmu.c " Randy Dunlap
2011-07-30 4:14 ` Randy Dunlap
2011-08-01 15:31 ` Len Brown
2011-08-01 15:31 ` Len Brown
2011-07-30 11:38 ` linux-next: Tree for July 29 Sedat Dilek
2011-07-30 16:08 ` Arnaud Lacombe
2011-07-30 16:16 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110731164208.GP15795@trinity.fluff.org \
--to=ben-i2c@fluff.org \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.