From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
rientjes@google.com
Subject: Re: Revert needed: udev spewing warnons on common systems in 3.0
Date: Mon, 1 Aug 2011 18:32:07 -0700 [thread overview]
Message-ID: <20110801183207.cea89a96.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110802005206.GA3832@tassilo.jf.intel.com>
On Mon, 1 Aug 2011 17:52:06 -0700 Andi Kleen <andi@firstfloor.org> wrote:
>
> Hi Linus,
>
> Can you please revert
>
> commit be8f684d73d8d916847e996bf69cef14352872c6
> Author: David Rientjes <rientjes@google.com>
> Date: Mon Jul 25 17:12:18 2011 -0700
>
> oom: make deprecated use of oom_adj more verbose
>
> /proc/pid/oom_adj is deprecated and scheduled for removal in August 2012
> according to Documentation/feature-removal-schedule.txt.
>
>
> This makes most of my test systems (suse 11.1, 11.2) spew scary WARN_ONs
> on every boot. GNOME then also complains.
aw, what crap.
"/proc/%d/oom_adj is deprecated, please use /proc/%d/oom_score_adj instead."
Once per boot. That's not "scary".
> While it doesn't cause actual
> misfunction it scares me every time I boot and other people who can't
> read git logs like me will be unnecessary scared.
What? Look at the damn text - the only reason anyone would need to
read a git log after looking at that is terminal cretinism.
> Also the warning is completely useless: noone will be "fixing"
> udev on old distributions.
I bet there were still old copies of /sbin/update lying around, but we
still managed to remove sys_bdflush() this way.
> IMHO that's not acceptable to break common user land like this.
> Linux is supposed to be binary compatible and this patch is not
> in this spirit.
>
> Actually removing the file later should be still fine, but
> not printing out these scary messages.
>
> I propose to revert this misguided patch for stable and 3.1
>
I see lots of fake reasoning. What's really going on here??
next prev parent reply other threads:[~2011-08-02 1:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 0:52 Revert needed: udev spewing warnons on common systems in 3.0 Andi Kleen
2011-08-02 1:32 ` Andrew Morton [this message]
2011-08-02 1:41 ` Linus Torvalds
2011-08-02 2:22 ` David Rientjes
2011-08-02 9:16 ` Alan Cox
2011-08-02 9:53 ` David Rientjes
2011-08-02 10:11 ` Alan Cox
2011-08-02 11:22 ` David Miller
2011-08-02 14:45 ` Andi Kleen
2011-08-02 21:50 ` David Rientjes
2011-08-02 21:45 ` David Rientjes
2011-08-02 22:06 ` Andi Kleen
2011-08-02 11:20 ` David Miller
2011-08-02 2:34 ` David Rientjes
2011-08-02 6:07 ` Andi Kleen
2011-08-02 9:54 ` [patch] oom: change warning for deprecated oom_adj to avoid WARN_ONCE() David Rientjes
2011-08-03 6:10 ` Borislav Petkov
2011-08-04 6:04 ` David Rientjes
2011-08-04 7:48 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801183207.cea89a96.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.