From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Edward Thornber <thornber@redhat.com>,
"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: Review of dm-block-manager.c
Date: Mon, 1 Aug 2011 17:17:29 -0400 [thread overview]
Message-ID: <20110801211729.GA11406@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1108011620590.9983@hs20-bc2-1.build.redhat.com>
On Mon, Aug 01 2011 at 5:00pm -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> Hi
>
> This is review of dm-block-manager.c:
>
>
> char buffer_cache_name[32];
> sprintf(bm->buffer_cache_name, "dm_block_buffer-%d:%d",
> --- it may not fit in 32 bytes.
It can accomodate nearly 1 trillion DM devices:
dm_block_buffer-253:9999999999
The goal is to move to using a common slab cache per blocksize long
before this limit becomes a concern.
Mike
next prev parent reply other threads:[~2011-08-01 21:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 21:00 Review of dm-block-manager.c Mikulas Patocka
2011-08-01 21:17 ` Mike Snitzer [this message]
2011-08-02 0:15 ` Mike Snitzer
2011-08-02 0:30 ` Mike Snitzer
2011-08-02 13:07 ` Joe Thornber
2011-08-02 13:29 ` Joe Thornber
2011-08-02 14:36 ` [PATCH 1/4] The return code from the various wait functions is never acted upon. So change to uninterrupible waits and change the return type to void Joe Thornber
2011-08-02 14:36 ` [PATCH 2/4] Fix a race between reading a new block and having it recycled Joe Thornber
2011-08-03 14:53 ` Mikulas Patocka
2011-08-02 14:36 ` [PATCH 3/4] [block-manager] remove spurious decrement of write_lock_pending in the case of a recycled block Joe Thornber
2011-08-03 14:50 ` Mikulas Patocka
2011-08-04 9:06 ` Joe Thornber
2011-08-02 14:36 ` [PATCH 4/4] Track errored blocks Joe Thornber
2011-08-03 15:00 ` Mikulas Patocka
2011-08-03 14:42 ` [PATCH 1/4] The return code from the various wait functions is never acted upon. So change to uninterrupible waits and change the return type to void Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801211729.GA11406@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=thornber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.