From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: Review of dm-block-manager.c Date: Mon, 1 Aug 2011 20:30:01 -0400 Message-ID: <20110802003000.GA12432@redhat.com> References: <20110801211729.GA11406@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20110801211729.GA11406@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka Cc: device-mapper development , Edward Thornber , "Alasdair G. Kergon" List-Id: dm-devel.ids On Mon, Aug 01 2011 at 5:17pm -0400, Mike Snitzer wrote: > On Mon, Aug 01 2011 at 5:00pm -0400, > Mikulas Patocka wrote: > > > Hi > > > > This is review of dm-block-manager.c: > > > > > > char buffer_cache_name[32]; > > sprintf(bm->buffer_cache_name, "dm_block_buffer-%d:%d", > > --- it may not fit in 32 bytes. > > It can accomodate nearly 1 trillion DM devices: > > dm_block_buffer-253:9999999999 Um, not nearly 1 trillion... no idea how I got that ;) (it's a moot point anyway).