All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH 2/7] MIPS: static should be at beginning of declaration
Date: Tue, 2 Aug 2011 10:24:38 +0100	[thread overview]
Message-ID: <20110802092438.GA18229@linux-mips.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1107092311190.25516@swampdragon.chaosbits.net>

On Sat, Jul 09, 2011 at 11:12:35PM +0200, Jesper Juhl wrote:

> Make sure that the 'static' keywork is at the beginning of declaration
> for arch/mips/include/asm/mach-jz4740/gpio.h
> 
> This gets rid of warnings like
>   warning: ‘static’ is not at beginning of declaration
> when building with -Wold-style-declaration (and/or -Wextra which also
> enables it).
> Also a few tiny whitespace changes.

> - const static struct jz_gpio_bulk_request i2c_pins[] = {
> + static const struct jz_gpio_bulk_request i2c_pins[] = {

Quite surprising - but that still was valid C - just type for example:

int typedef (*func(const char op))(int a, int b[static const a = 3]);

  Ralf

  reply	other threads:[~2011-08-02  9:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-09 21:08 [PATCH 0/7] static should be at beginning of declaration Jesper Juhl
2011-07-09 21:11 ` [PATCH 1/7] ARM: " Jesper Juhl
2011-07-09 21:11   ` Jesper Juhl
2011-07-09 21:11   ` Jesper Juhl
2011-07-09 21:12 ` [PATCH 2/7] MIPS: " Jesper Juhl
2011-08-02  9:24   ` Ralf Baechle [this message]
2011-07-09 21:16 ` [PATCH 3/7] SH: " Jesper Juhl
2011-07-09 21:16   ` Jesper Juhl
2011-07-09 21:17 ` [PATCH 4/7] XTENSA: " Jesper Juhl
     [not found] ` <alpine.LNX.2.00.1107092304160.25516-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2011-07-09 21:20   ` [PATCH 5/7] drivers/i2c: " Jesper Juhl
2011-07-09 21:20     ` Jesper Juhl
2011-07-09 21:22 ` [PATCH 6/7] drivers/media: " Jesper Juhl
2011-07-09 21:24 ` [PATCH 7/7] drivers/net: " Jesper Juhl
2011-07-12  5:15   ` David Miller
2011-07-12  5:15     ` David Miller
2011-07-11 12:16 ` [PATCH 0/7] " Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110802092438.GA18229@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=jj@chaosbits.net \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.