From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Lindner Date: Tue, 2 Aug 2011 10:28:21 +0200 Subject: [ath9k-devel] eeprom txGainType overridden if minor version < 19 Message-ID: <201108021028.21637.lindner_marek@yahoo.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Hi, I was having some output power problems with a device using AR7240/AR9285. After digging into the ath9k driver I realized that it would override the power settings (txGainType) configured in the eeprom if the minor version does not meet its expectations. This is why it would not use the appropriate high power settings. The offending lines from eeprom_4k.c: if (ver_minor >= AR5416_EEP_MINOR_VER_19) return pBase->txGainType; else return AR5416_EEP_TXGAIN_ORIGINAL; My minor version is 14 and consequently fell through the cracks. The commit introducing the check in question was 970bf9d40c03e48cc34ee2c1a70693a0e0fca3f6 but it does not explain why the minor version has to be 19 or higher. Does anyone know the magic behind version 19 ? I could easily post a patch to remove that check if it causes no harm. Regards, Marek