All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasily Khoruzhick <anarsoul@gmail.com>
To: libertas-dev@lists.infradead.org
Cc: Daniel Drake <dsd@laptop.org>,
	linville@tuxdriver.com, dcbw@redhat.com,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] libertas: disable functionality when interface is down
Date: Tue, 2 Aug 2011 13:12:22 +0300	[thread overview]
Message-ID: <201108021312.23153.anarsoul@gmail.com> (raw)
In-Reply-To: <201108021202.03890.anarsoul@gmail.com>

On Tuesday 02 August 2011 12:02:03 Vasily Khoruzhick wrote:
> On Monday 01 August 2011 18:43:13 Daniel Drake wrote:
> > Modify the driver so that it does not function when the interface is
> > down, in preparation for runtime power management.
> > 
> > No commands can be run while the interface is down, so the ndo_dev_stop
> > routine now directly does all necessary work (including asking the device
> > to disconnect from the network and disabling multicast functionality)
> > directly.
> > 
> > power_save and power_restore hooks are added meaning that card drivers
> > can take steps to turn the device off when the interface is down.
> > 
> > The MAC address can now only be changed when all interfaces are down;
> > the new address will be programmed when an interface gets brought up.
> > This matches mac80211 behaviour.
> > 
> > Also, some small cleanups/simplifications were made in the surrounding
> > device handling logic.
> 
> Ok, one more question: what about suspend? Maybe it worth to add flag to
> disable card before going suspend and re-enable it during resume?

Implemented it. The only remaining question is messing with power_{on,off} 
functions in if_sdio, but I'm OK with it. Will send my patches in few minutes.

Regards
Vasily

  reply	other threads:[~2011-08-02 10:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 15:43 [PATCH 1/2] libertas: disable functionality when interface is down Daniel Drake
2011-08-01 17:38 ` Vasily Khoruzhick
2011-08-01 17:50   ` Daniel Drake
2011-08-01 19:13     ` Vasily Khoruzhick
2011-08-01 19:19       ` Daniel Drake
2011-08-01 19:38         ` Vasily Khoruzhick
2011-08-02  9:02 ` Vasily Khoruzhick
2011-08-02 10:12   ` Vasily Khoruzhick [this message]
2011-08-02 10:27     ` [PATCH 1/2] libertas: add ability to power off card on suspend Vasily Khoruzhick
2011-08-02 10:27       ` [PATCH 2/2] libertas: implement if_spi runtime power management Vasily Khoruzhick
2011-08-02 10:54       ` [PATCH 1/2] libertas: add ability to power off card on suspend Daniel Drake
2011-08-02 20:09         ` Vasily Khoruzhick
2011-08-02 20:32           ` Daniel Drake
2011-08-02 21:12             ` Vasily Khoruzhick
2011-08-02 22:32               ` Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108021312.23153.anarsoul@gmail.com \
    --to=anarsoul@gmail.com \
    --cc=dcbw@redhat.com \
    --cc=dsd@laptop.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.