From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p73B6dLi149208 for ; Wed, 3 Aug 2011 06:06:39 -0500 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id ED15C1867373 for ; Wed, 3 Aug 2011 04:06:38 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id wmS2QP7rs2qTsUry for ; Wed, 03 Aug 2011 04:06:38 -0700 (PDT) Date: Wed, 3 Aug 2011 13:06:29 +0200 From: Johannes Weiner Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803110629.GB27199@redhat.com> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110803105819.GA27199@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mel Gorman Cc: Rik van Riel , Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Minchan Kim , Wu Fengguang On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote: > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote: > > Direct reclaim should never writeback pages. Warn if an attempt > > is made. > > > > Signed-off-by: Mel Gorman > > Acked-by: Johannes Weiner Oops, too fast. Shouldn't the WARN_ON() be at the top of the function, rather than just warn when the write is deferred due to delalloc? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865Ab1HCLGy (ORCPT ); Wed, 3 Aug 2011 07:06:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47063 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107Ab1HCLGs (ORCPT ); Wed, 3 Aug 2011 07:06:48 -0400 Date: Wed, 3 Aug 2011 13:06:29 +0200 From: Johannes Weiner To: Mel Gorman Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803110629.GB27199@redhat.com> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110803105819.GA27199@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote: > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote: > > Direct reclaim should never writeback pages. Warn if an attempt > > is made. > > > > Signed-off-by: Mel Gorman > > Acked-by: Johannes Weiner Oops, too fast. Shouldn't the WARN_ON() be at the top of the function, rather than just warn when the write is deferred due to delalloc? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id D9B0F6B0169 for ; Wed, 3 Aug 2011 07:06:38 -0400 (EDT) Date: Wed, 3 Aug 2011 13:06:29 +0200 From: Johannes Weiner Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803110629.GB27199@redhat.com> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110803105819.GA27199@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote: > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote: > > Direct reclaim should never writeback pages. Warn if an attempt > > is made. > > > > Signed-off-by: Mel Gorman > > Acked-by: Johannes Weiner Oops, too fast. Shouldn't the WARN_ON() be at the top of the function, rather than just warn when the write is deferred due to delalloc? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org