From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p73BJpeS149750 for ; Wed, 3 Aug 2011 06:19:51 -0500 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6313915F8F7D for ; Wed, 3 Aug 2011 04:20:39 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id TEUWZNGwGd5wFBFi for ; Wed, 03 Aug 2011 04:20:39 -0700 (PDT) Date: Wed, 3 Aug 2011 13:19:40 +0200 From: Johannes Weiner Subject: Re: [PATCH 6/8] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback Message-ID: <20110803111940.GD27199@redhat.com> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-7-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1311265730-5324-7-git-send-email-mgorman@suse.de> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mel Gorman Cc: Rik van Riel , Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Minchan Kim , Wu Fengguang On Thu, Jul 21, 2011 at 05:28:48PM +0100, Mel Gorman wrote: > Workloads that are allocating frequently and writing files place a > large number of dirty pages on the LRU. With use-once logic, it is > possible for them to reach the end of the LRU quickly requiring the > reclaimer to scan more to find clean pages. Ordinarily, processes that > are dirtying memory will get throttled by dirty balancing but this > is a global heuristic and does not take into account that LRUs are > maintained on a per-zone basis. This can lead to a situation whereby > reclaim is scanning heavily, skipping over a large number of pages > under writeback and recycling them around the LRU consuming CPU. > > This patch checks how many of the number of pages isolated from the > LRU were dirty. If a percentage of them are dirty, the process will be > throttled if a blocking device is congested or the zone being scanned > is marked congested. The percentage that must be dirty depends on > the priority. At default priority, all of them must be dirty. At > DEF_PRIORITY-1, 50% of them must be dirty, DEF_PRIORITY-2, 25% > etc. i.e. as pressure increases the greater the likelihood the process > will get throttled to allow the flusher threads to make some progress. > > Signed-off-by: Mel Gorman > --- > mm/vmscan.c | 21 ++++++++++++++++++--- > 1 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index cf7b501..b0060f8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -720,7 +720,8 @@ static noinline_for_stack void free_page_list(struct list_head *free_pages) > static unsigned long shrink_page_list(struct list_head *page_list, > struct zone *zone, > struct scan_control *sc, > - int priority) > + int priority, > + unsigned long *ret_nr_dirty) > { > LIST_HEAD(ret_pages); > LIST_HEAD(free_pages); > @@ -971,6 +972,7 @@ keep_lumpy: > > list_splice(&ret_pages, page_list); > count_vm_events(PGACTIVATE, pgactivate); > + *ret_nr_dirty += nr_dirty; Note that this includes anon pages, which means that swapping is throttled as well. I don't think it is a downside to throttle swapping during IO congestion - waiting for pages under writeback to become reclaimable is better than kicking off even more IO in this case as well - but the changelog and the comments should include it, I guess. Otherwise, Acked-by: Johannes Weiner _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754909Ab1HCLUF (ORCPT ); Wed, 3 Aug 2011 07:20:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34484 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753894Ab1HCLT7 (ORCPT ); Wed, 3 Aug 2011 07:19:59 -0400 Date: Wed, 3 Aug 2011 13:19:40 +0200 From: Johannes Weiner To: Mel Gorman Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 6/8] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback Message-ID: <20110803111940.GD27199@redhat.com> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-7-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311265730-5324-7-git-send-email-mgorman@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2011 at 05:28:48PM +0100, Mel Gorman wrote: > Workloads that are allocating frequently and writing files place a > large number of dirty pages on the LRU. With use-once logic, it is > possible for them to reach the end of the LRU quickly requiring the > reclaimer to scan more to find clean pages. Ordinarily, processes that > are dirtying memory will get throttled by dirty balancing but this > is a global heuristic and does not take into account that LRUs are > maintained on a per-zone basis. This can lead to a situation whereby > reclaim is scanning heavily, skipping over a large number of pages > under writeback and recycling them around the LRU consuming CPU. > > This patch checks how many of the number of pages isolated from the > LRU were dirty. If a percentage of them are dirty, the process will be > throttled if a blocking device is congested or the zone being scanned > is marked congested. The percentage that must be dirty depends on > the priority. At default priority, all of them must be dirty. At > DEF_PRIORITY-1, 50% of them must be dirty, DEF_PRIORITY-2, 25% > etc. i.e. as pressure increases the greater the likelihood the process > will get throttled to allow the flusher threads to make some progress. > > Signed-off-by: Mel Gorman > --- > mm/vmscan.c | 21 ++++++++++++++++++--- > 1 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index cf7b501..b0060f8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -720,7 +720,8 @@ static noinline_for_stack void free_page_list(struct list_head *free_pages) > static unsigned long shrink_page_list(struct list_head *page_list, > struct zone *zone, > struct scan_control *sc, > - int priority) > + int priority, > + unsigned long *ret_nr_dirty) > { > LIST_HEAD(ret_pages); > LIST_HEAD(free_pages); > @@ -971,6 +972,7 @@ keep_lumpy: > > list_splice(&ret_pages, page_list); > count_vm_events(PGACTIVATE, pgactivate); > + *ret_nr_dirty += nr_dirty; Note that this includes anon pages, which means that swapping is throttled as well. I don't think it is a downside to throttle swapping during IO congestion - waiting for pages under writeback to become reclaimable is better than kicking off even more IO in this case as well - but the changelog and the comments should include it, I guess. Otherwise, Acked-by: Johannes Weiner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id B899C6B0169 for ; Wed, 3 Aug 2011 07:19:50 -0400 (EDT) Date: Wed, 3 Aug 2011 13:19:40 +0200 From: Johannes Weiner Subject: Re: [PATCH 6/8] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback Message-ID: <20110803111940.GD27199@redhat.com> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-7-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311265730-5324-7-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim On Thu, Jul 21, 2011 at 05:28:48PM +0100, Mel Gorman wrote: > Workloads that are allocating frequently and writing files place a > large number of dirty pages on the LRU. With use-once logic, it is > possible for them to reach the end of the LRU quickly requiring the > reclaimer to scan more to find clean pages. Ordinarily, processes that > are dirtying memory will get throttled by dirty balancing but this > is a global heuristic and does not take into account that LRUs are > maintained on a per-zone basis. This can lead to a situation whereby > reclaim is scanning heavily, skipping over a large number of pages > under writeback and recycling them around the LRU consuming CPU. > > This patch checks how many of the number of pages isolated from the > LRU were dirty. If a percentage of them are dirty, the process will be > throttled if a blocking device is congested or the zone being scanned > is marked congested. The percentage that must be dirty depends on > the priority. At default priority, all of them must be dirty. At > DEF_PRIORITY-1, 50% of them must be dirty, DEF_PRIORITY-2, 25% > etc. i.e. as pressure increases the greater the likelihood the process > will get throttled to allow the flusher threads to make some progress. > > Signed-off-by: Mel Gorman > --- > mm/vmscan.c | 21 ++++++++++++++++++--- > 1 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index cf7b501..b0060f8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -720,7 +720,8 @@ static noinline_for_stack void free_page_list(struct list_head *free_pages) > static unsigned long shrink_page_list(struct list_head *page_list, > struct zone *zone, > struct scan_control *sc, > - int priority) > + int priority, > + unsigned long *ret_nr_dirty) > { > LIST_HEAD(ret_pages); > LIST_HEAD(free_pages); > @@ -971,6 +972,7 @@ keep_lumpy: > > list_splice(&ret_pages, page_list); > count_vm_events(PGACTIVATE, pgactivate); > + *ret_nr_dirty += nr_dirty; Note that this includes anon pages, which means that swapping is throttled as well. I don't think it is a downside to throttle swapping during IO congestion - waiting for pages under writeback to become reclaimable is better than kicking off even more IO in this case as well - but the changelog and the comments should include it, I guess. Otherwise, Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org