From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p73DiSpH155691 for ; Wed, 3 Aug 2011 08:44:28 -0500 Received: from mx2.suse.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 50FEF530D31 for ; Wed, 3 Aug 2011 06:44:26 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id S1NVAqr3UKCbKVKx for ; Wed, 03 Aug 2011 06:44:26 -0700 (PDT) Date: Wed, 3 Aug 2011 14:44:20 +0100 From: Mel Gorman Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803134420.GH19099@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> <20110803110629.GB27199@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110803110629.GB27199@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Johannes Weiner Cc: Rik van Riel , Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Minchan Kim , Wu Fengguang On Wed, Aug 03, 2011 at 01:06:29PM +0200, Johannes Weiner wrote: > On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote: > > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote: > > > Direct reclaim should never writeback pages. Warn if an attempt > > > is made. > > > > > > Signed-off-by: Mel Gorman > > > > Acked-by: Johannes Weiner > > Oops, too fast. > > Shouldn't the WARN_ON() be at the top of the function, rather than > just warn when the write is deferred due to delalloc? I thought it made more sense to put the warning at the point where ext4 would normally ignore ->writepage. That said, in my current revision of the series, I've dropped these patches altogether as page migration should be able to trigger the same warnings but be called from paths that are of less concern for stack overflows (or at the very least be looked at as a separate series). -- Mel Gorman SUSE Labs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566Ab1HCNod (ORCPT ); Wed, 3 Aug 2011 09:44:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34989 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056Ab1HCNo0 (ORCPT ); Wed, 3 Aug 2011 09:44:26 -0400 Date: Wed, 3 Aug 2011 14:44:20 +0100 From: Mel Gorman To: Johannes Weiner Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803134420.GH19099@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> <20110803110629.GB27199@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110803110629.GB27199@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2011 at 01:06:29PM +0200, Johannes Weiner wrote: > On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote: > > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote: > > > Direct reclaim should never writeback pages. Warn if an attempt > > > is made. > > > > > > Signed-off-by: Mel Gorman > > > > Acked-by: Johannes Weiner > > Oops, too fast. > > Shouldn't the WARN_ON() be at the top of the function, rather than > just warn when the write is deferred due to delalloc? I thought it made more sense to put the warning at the point where ext4 would normally ignore ->writepage. That said, in my current revision of the series, I've dropped these patches altogether as page migration should be able to trigger the same warnings but be called from paths that are of less concern for stack overflows (or at the very least be looked at as a separate series). -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id D58856B0169 for ; Wed, 3 Aug 2011 09:44:28 -0400 (EDT) Date: Wed, 3 Aug 2011 14:44:20 +0100 From: Mel Gorman Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803134420.GH19099@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> <20110803110629.GB27199@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110803110629.GB27199@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim On Wed, Aug 03, 2011 at 01:06:29PM +0200, Johannes Weiner wrote: > On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote: > > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote: > > > Direct reclaim should never writeback pages. Warn if an attempt > > > is made. > > > > > > Signed-off-by: Mel Gorman > > > > Acked-by: Johannes Weiner > > Oops, too fast. > > Shouldn't the WARN_ON() be at the top of the function, rather than > just warn when the write is deferred due to delalloc? I thought it made more sense to put the warning at the point where ext4 would normally ignore ->writepage. That said, in my current revision of the series, I've dropped these patches altogether as page migration should be able to trigger the same warnings but be called from paths that are of less concern for stack overflows (or at the very least be looked at as a separate series). -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org