From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p73DjDYN155753 for ; Wed, 3 Aug 2011 08:45:13 -0500 Received: from mx2.suse.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8900FF26DDD for ; Wed, 3 Aug 2011 06:46:00 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id JG8beQ7xHdMUoxKC for ; Wed, 03 Aug 2011 06:46:00 -0700 (PDT) Date: Wed, 3 Aug 2011 14:45:07 +0100 From: Mel Gorman Subject: Re: [PATCH 4/8] btrfs: Warn if direct reclaim tries to writeback pages Message-ID: <20110803134507.GI19099@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-5-git-send-email-mgorman@suse.de> <20110803111031.GC27199@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110803111031.GC27199@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Johannes Weiner Cc: Rik van Riel , Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Minchan Kim , Wu Fengguang On Wed, Aug 03, 2011 at 01:10:31PM +0200, Johannes Weiner wrote: > On Thu, Jul 21, 2011 at 05:28:46PM +0100, Mel Gorman wrote: > > Direct reclaim should never writeback pages. Warn if an attempt is > > made. By rights, btrfs should be allowing writepage from kswapd if > > it is failing to reclaim pages by any other means but it's outside > > the scope of this patch. > > > > Signed-off-by: Mel Gorman > > --- > > fs/btrfs/disk-io.c | 2 ++ > > fs/btrfs/inode.c | 2 ++ > > 2 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > > index 1ac8db5d..cc9c9cf 100644 > > --- a/fs/btrfs/disk-io.c > > +++ b/fs/btrfs/disk-io.c > > @@ -829,6 +829,8 @@ static int btree_writepage(struct page *page, struct writeback_control *wbc) > > > > tree = &BTRFS_I(page->mapping->host)->io_tree; > > if (!(current->flags & PF_MEMALLOC)) { > > + WARN_ON_ONCE((current->flags & (PF_MEMALLOC|PF_KSWAPD)) == > > + PF_MEMALLOC); > > Since it is branch for PF_MEMALLOC being set, why not just > WARN_ON_ONCE(!(current->flags & PF_KSWAPD)) instead? > > Minor nitpick, though, and I can understand if you just want to have > the conditionals be the same in every fs. > It was just copying the conditionals for the other FS although I admit your version would look nicer. -- Mel Gorman SUSE Labs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848Ab1HCNpS (ORCPT ); Wed, 3 Aug 2011 09:45:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35024 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361Ab1HCNpL (ORCPT ); Wed, 3 Aug 2011 09:45:11 -0400 Date: Wed, 3 Aug 2011 14:45:07 +0100 From: Mel Gorman To: Johannes Weiner Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 4/8] btrfs: Warn if direct reclaim tries to writeback pages Message-ID: <20110803134507.GI19099@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-5-git-send-email-mgorman@suse.de> <20110803111031.GC27199@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110803111031.GC27199@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2011 at 01:10:31PM +0200, Johannes Weiner wrote: > On Thu, Jul 21, 2011 at 05:28:46PM +0100, Mel Gorman wrote: > > Direct reclaim should never writeback pages. Warn if an attempt is > > made. By rights, btrfs should be allowing writepage from kswapd if > > it is failing to reclaim pages by any other means but it's outside > > the scope of this patch. > > > > Signed-off-by: Mel Gorman > > --- > > fs/btrfs/disk-io.c | 2 ++ > > fs/btrfs/inode.c | 2 ++ > > 2 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > > index 1ac8db5d..cc9c9cf 100644 > > --- a/fs/btrfs/disk-io.c > > +++ b/fs/btrfs/disk-io.c > > @@ -829,6 +829,8 @@ static int btree_writepage(struct page *page, struct writeback_control *wbc) > > > > tree = &BTRFS_I(page->mapping->host)->io_tree; > > if (!(current->flags & PF_MEMALLOC)) { > > + WARN_ON_ONCE((current->flags & (PF_MEMALLOC|PF_KSWAPD)) == > > + PF_MEMALLOC); > > Since it is branch for PF_MEMALLOC being set, why not just > WARN_ON_ONCE(!(current->flags & PF_KSWAPD)) instead? > > Minor nitpick, though, and I can understand if you just want to have > the conditionals be the same in every fs. > It was just copying the conditionals for the other FS although I admit your version would look nicer. -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 6FBBE6B016A for ; Wed, 3 Aug 2011 09:45:13 -0400 (EDT) Date: Wed, 3 Aug 2011 14:45:07 +0100 From: Mel Gorman Subject: Re: [PATCH 4/8] btrfs: Warn if direct reclaim tries to writeback pages Message-ID: <20110803134507.GI19099@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-5-git-send-email-mgorman@suse.de> <20110803111031.GC27199@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110803111031.GC27199@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim On Wed, Aug 03, 2011 at 01:10:31PM +0200, Johannes Weiner wrote: > On Thu, Jul 21, 2011 at 05:28:46PM +0100, Mel Gorman wrote: > > Direct reclaim should never writeback pages. Warn if an attempt is > > made. By rights, btrfs should be allowing writepage from kswapd if > > it is failing to reclaim pages by any other means but it's outside > > the scope of this patch. > > > > Signed-off-by: Mel Gorman > > --- > > fs/btrfs/disk-io.c | 2 ++ > > fs/btrfs/inode.c | 2 ++ > > 2 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > > index 1ac8db5d..cc9c9cf 100644 > > --- a/fs/btrfs/disk-io.c > > +++ b/fs/btrfs/disk-io.c > > @@ -829,6 +829,8 @@ static int btree_writepage(struct page *page, struct writeback_control *wbc) > > > > tree = &BTRFS_I(page->mapping->host)->io_tree; > > if (!(current->flags & PF_MEMALLOC)) { > > + WARN_ON_ONCE((current->flags & (PF_MEMALLOC|PF_KSWAPD)) == > > + PF_MEMALLOC); > > Since it is branch for PF_MEMALLOC being set, why not just > WARN_ON_ONCE(!(current->flags & PF_KSWAPD)) instead? > > Minor nitpick, though, and I can understand if you just want to have > the conditionals be the same in every fs. > It was just copying the conditionals for the other FS although I admit your version would look nicer. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org