From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p73EII2M156934 for ; Wed, 3 Aug 2011 09:18:23 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 584BC186767D for ; Wed, 3 Aug 2011 07:18:17 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id 8DMCaWnOfC5UqOkq for ; Wed, 03 Aug 2011 07:18:17 -0700 (PDT) Date: Wed, 3 Aug 2011 10:18:07 -0400 From: Christoph Hellwig Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803141807.GA7676@infradead.org> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> <20110803110629.GB27199@redhat.com> <20110803134420.GH19099@suse.de> <20110803140019.GA31026@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110803140019.GA31026@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Johannes Weiner Cc: Rik van Riel , Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Mel Gorman , Wu Fengguang , josef@redhat.com, Minchan Kim On Wed, Aug 03, 2011 at 04:00:19PM +0200, Johannes Weiner wrote: > > That said, in my current revision of the series, I've dropped these > > patches altogether as page migration should be able to trigger the same > > warnings but be called from paths that are of less concern for stack > > overflows (or at the very least be looked at as a separate series). > > Doesn't this only apply to btrfs which has no own .migratepage aop for > file pages? The others use buffer_migrate_page. > > But if you dropped them anyway, it does not matter :) Note that the mid-term plan is to kill ->writepage as an address space method. Besides the usage from reclaim as as callbacks to write_cache_pages and write_one_page (which can be made explicit arguments) the only remaining user is the above mentioned fallback. Josef, any chance you could switch btrfs over to implement a proper ->migratepage? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141Ab1HCOSU (ORCPT ); Wed, 3 Aug 2011 10:18:20 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:49934 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753527Ab1HCOSQ (ORCPT ); Wed, 3 Aug 2011 10:18:16 -0400 Date: Wed, 3 Aug 2011 10:18:07 -0400 From: Christoph Hellwig To: Johannes Weiner Cc: Mel Gorman , Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim , josef@redhat.com Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803141807.GA7676@infradead.org> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> <20110803110629.GB27199@redhat.com> <20110803134420.GH19099@suse.de> <20110803140019.GA31026@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110803140019.GA31026@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2011 at 04:00:19PM +0200, Johannes Weiner wrote: > > That said, in my current revision of the series, I've dropped these > > patches altogether as page migration should be able to trigger the same > > warnings but be called from paths that are of less concern for stack > > overflows (or at the very least be looked at as a separate series). > > Doesn't this only apply to btrfs which has no own .migratepage aop for > file pages? The others use buffer_migrate_page. > > But if you dropped them anyway, it does not matter :) Note that the mid-term plan is to kill ->writepage as an address space method. Besides the usage from reclaim as as callbacks to write_cache_pages and write_one_page (which can be made explicit arguments) the only remaining user is the above mentioned fallback. Josef, any chance you could switch btrfs over to implement a proper ->migratepage? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 21AEE6B0169 for ; Wed, 3 Aug 2011 10:18:18 -0400 (EDT) Date: Wed, 3 Aug 2011 10:18:07 -0400 From: Christoph Hellwig Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages Message-ID: <20110803141807.GA7676@infradead.org> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-4-git-send-email-mgorman@suse.de> <20110803105819.GA27199@redhat.com> <20110803110629.GB27199@redhat.com> <20110803134420.GH19099@suse.de> <20110803140019.GA31026@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110803140019.GA31026@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Mel Gorman , Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim , josef@redhat.com On Wed, Aug 03, 2011 at 04:00:19PM +0200, Johannes Weiner wrote: > > That said, in my current revision of the series, I've dropped these > > patches altogether as page migration should be able to trigger the same > > warnings but be called from paths that are of less concern for stack > > overflows (or at the very least be looked at as a separate series). > > Doesn't this only apply to btrfs which has no own .migratepage aop for > file pages? The others use buffer_migrate_page. > > But if you dropped them anyway, it does not matter :) Note that the mid-term plan is to kill ->writepage as an address space method. Besides the usage from reclaim as as callbacks to write_cache_pages and write_one_page (which can be made explicit arguments) the only remaining user is the above mentioned fallback. Josef, any chance you could switch btrfs over to implement a proper ->migratepage? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org