From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoePL-0006Cx-35 for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:34:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoePK-0007f6-FE for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:34:59 -0400 Received: from verein.lst.de ([213.95.11.211]:56959 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoePK-0007f1-AF for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:34:58 -0400 Date: Wed, 3 Aug 2011 18:34:57 +0200 From: Christoph Hellwig Message-ID: <20110803163457.GE8411@lst.de> References: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> <1312361359-15445-5-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312361359-15445-5-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/16] scsi: move sense handling to generic code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Wed, Aug 03, 2011 at 10:49:07AM +0200, Paolo Bonzini wrote: > With this patch, sense data is stored in the generic data structures > for SCSI devices and requests. The SCSI layer takes care of storing > sense data in the SCSIDevice for the subsequent REQUEST SENSE command. > > At the same time, get_sense is removed and scsi_req_get_sense can use > an entirely generic implementation. > > Signed-off-by: Paolo Bonzini Looks sensible to me, Reviewed-by: Christoph Hellwig