All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <padovan@profusion.mobi>
To: Anderson Briglia <anderson.briglia@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 1/7] Bluetooth: Add RSSI Monitor commands
Date: Wed, 3 Aug 2011 14:58:10 -0300	[thread overview]
Message-ID: <20110803175810.GC28119@joana> (raw)
In-Reply-To: <1312310109-27082-2-git-send-email-anderson.briglia@openbossa.org>

Hi Briglia,

* Anderson Briglia <anderson.briglia@openbossa.org> [2011-08-02 14:35:03 -0400]:

> This patch adds two new Management commands: Enable/Disable RSSI
> Monitor. This command is used to handle a list of monitors in order to
> monitor the RSSI value of a connection. It is useful on Proximity
> profile implementation.
> 
> Signed-off-by: Anderson Briglia <anderson.briglia@openbossa.org>
> ---
>  include/net/bluetooth/mgmt.h |   12 ++++++++++++
>  net/bluetooth/mgmt.c         |   22 ++++++++++++++++++++++
>  2 files changed, 34 insertions(+), 0 deletions(-)
> 
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index 5428fd3..ef3b636 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -211,6 +211,18 @@ struct mgmt_cp_unblock_device {
>  	bdaddr_t bdaddr;
>  } __packed;
>  
> +#define MGMT_OP_ENABLE_RSSI_MONITOR	0x001F
> +struct mgmt_cp_enable_rssi_monitor {
> +	bdaddr_t bdaddr;
> +	__s8 low_alert_trigger;
> +	__s8 high_alert_trigger;
> +} __packed;
> +
> +#define MGMT_OP_DISABLE_RSSI_MONITOR	0x0020
> +struct mgmt_cp_disable_rssi_monitor {
> +	bdaddr_t bdaddr;
> +} __packed;
> +

Make much more sense to me call this ADD/REMOVE. We add an rssi monitor to the
list and then remove it from the list. 

	Gustavo

  reply	other threads:[~2011-08-03 17:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 18:35 [RFC 0/7] RSSI Monitor Anderson Briglia
2011-08-02 18:35 ` [RFC 1/7] Bluetooth: Add RSSI Monitor commands Anderson Briglia
2011-08-03 17:58   ` Gustavo Padovan [this message]
2011-08-03 18:04     ` Anderson Briglia
2011-08-02 18:35 ` [RFC 2/7] Bluetooth: Implement Enable RSSI Monitor Anderson Briglia
2011-08-02 18:35 ` [RFC 3/7] Bluetooth: Implement Disable " Anderson Briglia
2011-08-02 18:35 ` [RFC 4/7] Bluetooth: Implement RSSI Monitor Alert event Anderson Briglia
2011-08-02 18:35 ` [RFC 5/7] Bluetooth: Implement Read RSSI command Anderson Briglia
2011-08-02 18:35 ` [RFC 6/7] Bluetooth: Add RSSI Monitor timer and list lock Anderson Briglia
2011-08-03 18:48   ` Gustavo Padovan
2011-08-03 19:09     ` Anderson Briglia
2011-08-03 19:18       ` Gustavo Padovan
2011-08-03 19:01   ` Claudio Takahasi
2011-08-03 19:10     ` Anderson Briglia
2011-08-02 18:35 ` [RFC 7/7] Bluetooth: Remove RSSI monitor on disconnection Anderson Briglia
2011-08-03 19:36 ` [RFC 0/7] RSSI Monitor Claudio Takahasi
2011-08-03 20:25   ` Gustavo Padovan
2011-08-03 20:52     ` Claudio Takahasi
2011-08-03 21:52       ` Anderson Briglia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110803175810.GC28119@joana \
    --to=padovan@profusion.mobi \
    --cc=anderson.briglia@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.