From: Greg KH <greg@kroah.com>
To: Paul Clements <paul.clements@us.sios.com>
Cc: andrew morton <akpm@linux-foundation.org>,
kernel list <linux-kernel@vger.kernel.org>,
nbd-general@lists.sourceforge.net
Subject: Re: [PATCH] nbd: nbd sysfs framework
Date: Wed, 3 Aug 2011 22:22:39 -0700 [thread overview]
Message-ID: <20110804052239.GA12523@kroah.com> (raw)
In-Reply-To: <CAECXXi5pkRAY_dVSwSUrj5RQzsJ2YVx6xXovzpuRDOEOq92s9g@mail.gmail.com>
On Wed, Aug 03, 2011 at 10:17:04PM -0400, Paul Clements wrote:
> On Wed, Aug 3, 2011 at 7:34 PM, Greg KH <greg@kroah.com> wrote:
> > On Wed, Aug 03, 2011 at 07:15:51PM -0400, Paul Clements wrote:
> >> Description: The patch creates a new sysfs entry framework for nbd.
> >
> > Why? What does this buy us except an increase in code size for no added
> > benifit? You seem to be stripping out the driver layer here and using
> > "raw" kobjects, why?
>
> Not sure what I was thinking...just in a hurry, I think.
>
> Is the following a little better?
I don't know, I still fail to understand _why_ this patch is needed.
Why are you doing this? What is the goal? What is wrong with the
existing code that it doesn't work for you?
confused,
greg k-h
next prev parent reply other threads:[~2011-08-04 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 23:15 [PATCH] nbd: nbd sysfs framework Paul Clements
2011-08-03 23:34 ` Greg KH
2011-08-04 2:17 ` Paul Clements
2011-08-04 5:22 ` Greg KH [this message]
2011-08-04 16:31 ` Paul Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804052239.GA12523@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
--cc=paul.clements@us.sios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.