From: Greg KH <gregkh@suse.de>
To: "Liu, ShuoX" <shuox.liu@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] PM: add statistics sysfs file for suspend to ram
Date: Wed, 3 Aug 2011 22:27:29 -0700 [thread overview]
Message-ID: <20110804052729.GA12707@suse.de> (raw)
In-Reply-To: <6E3BC7F7C9A4BF4286DD4C043110F30B5B790E5741@shsmsx502.ccr.corp.intel.com>
On Thu, Aug 04, 2011 at 01:13:38PM +0800, Liu, ShuoX wrote:
> >From a906b0b5b4ff3414ceb9fc7a69a3d7c9d66e46b1 Mon Sep 17 00:00:00 2001
> From: ShuoX Liu <shuox.liu@intel.com>
> Date: Thu, 28 Jul 2011 10:54:22 +0800
> Subject: [PATCH] PM: add statistics sysfs file for suspend to ram.
What's this stuff here for? That's not needed (hint, I would have to
edit it out by hand to be able to apply this patch.)
Thanks for resending a version that passes checkpatch.pl and could be
applied, but all of my previous comments still stand. This patch, as
is, is totally unacceptable.
greg k-h
next prev parent reply other threads:[~2011-08-04 5:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 5:13 [PATCH] PM: add statistics sysfs file for suspend to ram Liu, ShuoX
2011-08-04 5:27 ` Greg KH [this message]
2011-08-04 9:32 ` Rafael J. Wysocki
2011-08-05 1:57 ` Liu, ShuoX
2011-08-05 3:19 ` Yanmin Zhang
2011-08-05 19:20 ` Rafael J. Wysocki
2011-08-08 3:48 ` Yanmin Zhang
2011-08-08 20:37 ` Rafael J. Wysocki
2011-08-08 21:01 ` Greg KH
2011-08-08 21:05 ` Pavel Machek
2011-08-08 21:14 ` Rafael J. Wysocki
2011-08-08 21:54 ` Pavel Machek
2011-08-08 22:09 ` Rafael J. Wysocki
2011-08-10 22:27 ` Pavel Machek
2011-08-11 19:48 ` Rafael J. Wysocki
2011-08-04 19:05 ` Len Brown
2011-08-04 19:17 ` Randy Dunlap
2011-08-04 19:50 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2011-08-04 5:09 Liu, ShuoX
2011-08-04 5:16 ` Greg KH
2011-08-04 5:17 ` Greg KH
2011-08-03 17:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804052729.GA12707@suse.de \
--to=gregkh@suse.de \
--cc=len.brown@intel.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=shuox.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.