From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW daemons/clvmd/clvmd-singlenode.c
Date: 4 Aug 2011 12:13:52 -0000 [thread overview]
Message-ID: <20110804121352.21061.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2011-08-04 12:13:51
Modified files:
. : WHATS_NEW
daemons/clvmd : clvmd-singlenode.c
Log message:
Add test for fcntl error in singlenode client code.
Static analyzer noticed this check could be handy.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2048&r2=1.2049
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-singlenode.c.diff?cvsroot=lvm2&r1=1.10&r2=1.11
--- LVM2/WHATS_NEW 2011/08/04 10:14:42 1.2048
+++ LVM2/WHATS_NEW 2011/08/04 12:13:50 1.2049
@@ -1,5 +1,6 @@
Version 2.02.87 -
===============================
+ Add test for fcntl error in singlenode client code.
Remove --force option from lvrename manpage.
Add missing new line in lvrename help text.
Add basic support for RAID 1/4/5/6 (i.e. create, remove, display)
--- LVM2/daemons/clvmd/clvmd-singlenode.c 2011/03/24 10:45:00 1.10
+++ LVM2/daemons/clvmd/clvmd-singlenode.c 2011/08/04 12:13:51 1.11
@@ -55,7 +55,10 @@
goto error;
}
/* Set Close-on-exec */
- fcntl(listen_fd, F_SETFD, 1);
+ if (fcntl(listen_fd, F_SETFD, 1)) {
+ DEBUGLOG("Setting CLOEXEC on client fd faile: %s\n", strerror(errno));
+ goto error;
+ }
memset(&addr, 0, sizeof(addr));
memcpy(addr.sun_path, SINGLENODE_CLVMD_SOCKNAME,
next reply other threads:[~2011-08-04 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 12:13 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 12:16 LVM2 ./WHATS_NEW daemons/clvmd/clvmd-singlenode.c zkabelac
2011-10-11 9:05 zkabelac
2010-03-26 15:45 snitzer
2010-03-29 14:38 ` Petr Rockai
2010-03-29 15:13 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804121352.21061.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.