From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
632923@bugs.debian.org, Christian Ohm <chr.ohm@gmx.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: do not look at ./config for configuration
Date: Fri, 5 Aug 2011 14:34:47 -0300 [thread overview]
Message-ID: <20110805173447.GC14925@ghostprotocols.net> (raw)
In-Reply-To: <20110805165838.GA7237@elie.gateway.2wire.net>
Em Fri, Aug 05, 2011 at 06:58:38PM +0200, Jonathan Nieder escreveu:
> In addition to /etc/perfconfig and $HOME/.perfconfig, perf looks for
> configuration in the file ./config, imitating git which looks at
> $GIT_DIR/config. If ./config is not a perf configuration file, it
> fails, or worse, treats it as a configuration file and changes
> behavior in some unexpected way.
>
> "config" is not an unusual name for a file to be lying around and perf
> does not have a private directory dedicated for its own use, so let's
> just stop looking for configuration in the cwd. Callers needing
> context-sensitive configuration can use the PERF_CONFIG environment
> variable.
Thanks, I'll apply this one.
- Arnaldo
next prev parent reply other threads:[~2011-08-05 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110707024506.GA32088@moongate.localnet>
2011-07-07 3:55 ` Bug#632923: linux-tools-2.6.39: perf tries to read ./config, fails if it is not a perf config file Ben Hutchings
2011-08-05 16:58 ` [PATCH] perf: do not look at ./config for configuration Jonathan Nieder
2011-08-05 17:34 ` Arnaldo Carvalho de Melo [this message]
2011-08-10 8:26 ` [tip:perf/urgent] perf tools: " tip-bot for Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805173447.GC14925@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=632923@bugs.debian.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ben@decadent.org.uk \
--cc=chr.ohm@gmx.net \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.