From: Pavel Roskin <proski@gnu.org>
To: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
Cc: Daniel Halperin <dhalperi@cs.washington.edu>,
emmanuel.grumbach@intel.com,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH wireless-3.1] iwlagn: sysfs couldn't find the priv pointer
Date: Fri, 5 Aug 2011 22:50:51 -0400 [thread overview]
Message-ID: <20110805225051.435fe1b0@mj> (raw)
In-Reply-To: <1312499702.15170.17.camel@wwguy-huron>
On Thu, 04 Aug 2011 16:15:02 -0700
"Guy, Wey-Yi" <wey-yi.w.guy@intel.com> wrote:
> Could you look into this, we need to fix it for 3.1
The backtrace looked interesting to me, so I checked the code.
It looks like iwl_pci_down() badly needs to be merged with
iwl_pci_remove(). iwl_pci_down() is only called from iwl_pci_remove(),
and is struggles badly to get the data that iwl_pci_remove() already
has. That may fix everything. Unfortunately, I have no hardware to
test it.
pci_bus->pci_dev that iwl_pci_down() passes to pci_disable_msi() should
be the same as pdev in iwl_pci_remove(). And pdev should be valid
throughout the function.
Also, the use of the void pointer in iwl_pci_remove() seems
unjustified. Specific pointers are always better.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-08-06 2:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 19:46 [PATCH wireless-3.1] iwlagn: sysfs couldn't find the priv pointer Wey-Yi Guy
2011-08-02 3:53 ` Daniel Halperin
2011-08-02 5:50 ` Grumbach, Emmanuel
2011-08-02 6:39 ` Daniel Halperin
2011-08-04 20:55 ` Daniel Halperin
2011-08-04 23:15 ` Guy, Wey-Yi
2011-08-06 2:50 ` Pavel Roskin [this message]
2011-08-06 18:17 ` Guy, Wey-Yi W
2011-08-06 19:43 ` Emmanuel Grumbach
2011-08-06 19:45 ` Grumbach, Emmanuel
2011-08-07 5:09 ` Grumbach, Emmanuel
2011-08-07 6:21 ` Guy, Wey-Yi W
2011-08-08 14:27 ` John W. Linville
2011-08-08 16:19 ` Grumbach, Emmanuel
2011-08-09 14:38 ` Mohammed Shafi
2011-08-09 19:23 ` Grumbach, Emmanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805225051.435fe1b0@mj \
--to=proski@gnu.org \
--cc=dhalperi@cs.washington.edu \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.