From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Danny Huang <dahuang@nvidia.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
"mike@compulab.co.il" <mike@compulab.co.il>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Xin Xie <xxie@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: tps6586x: add SMx slew rate setting
Date: Mon, 8 Aug 2011 18:37:05 +0900 [thread overview]
Message-ID: <20110808093703.GC12376@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1BA5D2DFD2730747A2B3725B59933B93C07A47561C@HKMAIL01.nvidia.com>
On Fri, Aug 05, 2011 at 07:51:15PM +0800, Danny Huang wrote:
> Thanks for the feedback.
> The reason for using driver_data is that I can't find a proper field in regulator_init_data for the slew rate setting.
> I'll do some correction based on the feedback and try to add a new field for the slew rate setting.
No, this is OK - we should really rename the driver_data field, it's
very misleading. However:
> + return tps6586x_write(parent, reg, setting->slew_rate);
what happens if the user sets zero for the slew rate (eg, if another
field is added to the platform data that they want to set)? Is this a
sane setting (like the chip default) or might it break something?
next prev parent reply other threads:[~2011-08-08 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 11:34 [PATCH] regulator: tps6586x: add SMx slew rate setting dahuang
2011-08-04 12:12 ` Mark Brown
2011-08-05 11:51 ` Danny Huang
2011-08-08 9:37 ` Mark Brown [this message]
2011-08-08 12:28 ` Danny Huang
2011-08-08 13:32 ` Mark Brown
2011-08-04 12:42 ` Mark Brown
2011-08-05 11:53 ` Danny Huang
-- strict thread matches above, loose matches on Subject: below --
2011-08-09 10:47 dahuang
2011-08-09 16:06 ` Mark Brown
2011-08-22 9:35 ` Samuel Ortiz
2011-08-22 9:41 ` Liam Girdwood
2011-08-28 16:49 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808093703.GC12376@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dahuang@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=mike@compulab.co.il \
--cc=sameo@linux.intel.com \
--cc=xxie@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.