From: "George Spelvin" <linux@horizon.com>
To: joakim.tjernlund@transmode.se, linux@horizon.com
Cc: akpm@linux-foundation.org, fzago@systemfabricworks.com,
linux-kernel@vger.kernel.org, rpearson@systemfabricworks.com
Subject: Re: [PATCH] add slice by 8 algorithm to crc32.c
Date: 8 Aug 2011 06:52:01 -0400 [thread overview]
Message-ID: <20110808105201.25396.qmail@science.horizon.com> (raw)
In-Reply-To: <OF53580ACE.F420CB68-ONC12578E6.0039189A-C12578E6.0039CD0F@transmode.se>
> I prefer to keep the current code which (at the time) generated good code
> for at least ppc:
> /* Align it */
> if (unlikely((long)buf & 3 && len)) {
> do {
> DO_CRC(*buf++);
> } while ((--len) && ((long)buf)&3);
> }
Ah, I was looking at fzago's initial patch; I hadn't realized you'd
tweaked it. That's pretty much what I was talking about.
Would
if (unlikely((long)buf & 3) && len) {
give the compiler better hints? len != 0 is awfully
likely, actually.
next prev parent reply other threads:[~2011-08-08 10:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 9:28 [PATCH] add slice by 8 algorithm to crc32.c George Spelvin
2011-08-08 10:31 ` Joakim Tjernlund
2011-08-08 10:52 ` George Spelvin [this message]
2011-08-08 11:11 ` Joakim Tjernlund
2011-08-08 17:04 ` Bob Pearson
[not found] ` <OFEA1BD2B2.B2A7F07F-ONC12578E6.003D368C-C12578E6.003D7468@LocalDomain>
2011-08-08 11:24 ` Joakim Tjernlund
2011-08-08 11:42 ` Joakim Tjernlund
2011-08-08 12:54 ` George Spelvin
2011-08-08 17:01 ` Bob Pearson
2011-08-08 20:45 ` George Spelvin
2011-08-08 22:21 ` Bob Pearson
2011-08-08 16:54 ` Bob Pearson
2011-08-08 16:50 ` Bob Pearson
[not found] <OF4AE0115F.3AA5397E-ONC12578DF.002EC6DF-C12578DF.003348E5@transmode.se>
2011-08-02 21:14 ` Bob Pearson
2011-08-02 21:19 ` Bob Pearson
2011-08-04 11:54 ` Joakim Tjernlund
2011-08-04 18:53 ` Bob Pearson
2011-08-05 9:22 ` Joakim Tjernlund
2011-08-05 15:51 ` Bob Pearson
2011-08-08 7:11 ` Joakim Tjernlund
2011-08-05 17:27 ` Bob Pearson
2011-08-08 7:15 ` Joakim Tjernlund
[not found] ` <OF14136E0E.3F2388EF-ONC12578E3.00301969-C12578E3.00338524@LocalDomain>
2011-08-05 13:34 ` Joakim Tjernlund
-- strict thread matches above, loose matches on Subject: below --
2011-07-20 22:19 frank zago
2011-07-28 22:16 ` Andrew Morton
2011-07-29 1:47 ` Bob Pearson
2011-08-01 19:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808105201.25396.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=akpm@linux-foundation.org \
--cc=fzago@systemfabricworks.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=rpearson@systemfabricworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.