From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init Date: Mon, 8 Aug 2011 15:56:47 +0300 Message-ID: <20110808125647.GA27643@redhat.com> References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-2-git-send-email-avi@redhat.com> <4E3BF599.4050207@codemonkey.ws> <20110808103606.GA10372@redhat.com> <4E3FDA5F.5050105@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28287 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451Ab1HHM4I (ORCPT ); Mon, 8 Aug 2011 08:56:08 -0400 Content-Disposition: inline In-Reply-To: <4E3FDA5F.5050105@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Aug 08, 2011 at 07:45:19AM -0500, Anthony Liguori wrote: > On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote: > >>Thinking more closely, I don't think this right. > >> > >>Updating on map ensured that the config was refreshed after each > >>time the bar was mapped. In the very least, the config needs to be > >>refreshed during reset because the guest may write to the guest > >>space which should get cleared after reset. > >> > >>Regards, > >> > >>Anthony Liguori > > > >Not sure I understand. Which register, for example, > >do you have in mind? > >Could you clarify please? > > Actually, you never need to call config_get() AFAICT. It's called > in every read/write access. Every read, yes. But every write? Are you sure? > So I think the code you changed is > extraneous now. > > Regards, > > Anthony Liguori -- MST