All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Morell <rmorell@nvidia.com>
To: Dilan Lee <dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org"
	<rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
	"lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org"
	<lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>,
	"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"arun.murthy-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org"
	<arun.murthy-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
	"linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org"
	<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
	Jordan Nien <JNien-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] video: Add a callback 'notify_after' for backlight
Date: Tue, 09 Aug 2011 02:12:58 +0000	[thread overview]
Message-ID: <20110809021258.GM27748@morell.nvidia.com> (raw)
In-Reply-To: <1312855525-21464-1-git-send-email-dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On Mon, Aug 08, 2011 at 07:05:25PM -0700, Dilan Lee wrote:
[...]
> For example, GPIO backlight_en has to be risen after pwm has been enabled
> to meet panel power on sequence defined in panel specification.

I still think this information is irrelevant/nonsensical here, and
should be omitted entirely..

[...]

>  	unsigned int		lth_brightness;
>  	int			(*notify)(struct device *,
> -					  int brightness);
> +					int brightness);

Please don't change the line above; unlike the one you added after, it
was already lined up properly with its argument list.

Otherwise,
Reviewed-by: Robert Morell <rmorell@nvidia.com>

WARNING: multiple messages have this Message-ID (diff)
From: Robert Morell <rmorell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Dilan Lee <dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org"
	<rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
	"lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org"
	<lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>,
	"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"arun.murthy-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org"
	<arun.murthy-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
	"linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org"
	<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
	Jordan Nien <JNien-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] video: Add a callback 'notify_after' for backlight control
Date: Mon, 8 Aug 2011 19:12:58 -0700	[thread overview]
Message-ID: <20110809021258.GM27748@morell.nvidia.com> (raw)
In-Reply-To: <1312855525-21464-1-git-send-email-dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On Mon, Aug 08, 2011 at 07:05:25PM -0700, Dilan Lee wrote:
[...]
> For example, GPIO backlight_en has to be risen after pwm has been enabled
> to meet panel power on sequence defined in panel specification.

I still think this information is irrelevant/nonsensical here, and
should be omitted entirely..

[...]

>  	unsigned int		lth_brightness;
>  	int			(*notify)(struct device *,
> -					  int brightness);
> +					int brightness);

Please don't change the line above; unlike the one you added after, it
was already lined up properly with its argument list.

Otherwise,
Reviewed-by: Robert Morell <rmorell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

WARNING: multiple messages have this Message-ID (diff)
From: Robert Morell <rmorell@nvidia.com>
To: Dilan Lee <dilee@nvidia.com>
Cc: "rpurdie@rpsys.net" <rpurdie@rpsys.net>,
	"lethal@linux-sh.org" <lethal@linux-sh.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"arun.murthy@stericsson.com" <arun.murthy@stericsson.com>,
	"linus.walleij@stericsson.com" <linus.walleij@stericsson.com>,
	Jordan Nien <JNien@nvidia.com>,
	Stephen Warren <swarren@nvidia.com>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] video: Add a callback 'notify_after' for backlight control
Date: Mon, 8 Aug 2011 19:12:58 -0700	[thread overview]
Message-ID: <20110809021258.GM27748@morell.nvidia.com> (raw)
In-Reply-To: <1312855525-21464-1-git-send-email-dilee@nvidia.com>

On Mon, Aug 08, 2011 at 07:05:25PM -0700, Dilan Lee wrote:
[...]
> For example, GPIO backlight_en has to be risen after pwm has been enabled
> to meet panel power on sequence defined in panel specification.

I still think this information is irrelevant/nonsensical here, and
should be omitted entirely..

[...]

>  	unsigned int		lth_brightness;
>  	int			(*notify)(struct device *,
> -					  int brightness);
> +					int brightness);

Please don't change the line above; unlike the one you added after, it
was already lined up properly with its argument list.

Otherwise,
Reviewed-by: Robert Morell <rmorell@nvidia.com>

  parent reply	other threads:[~2011-08-09  2:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09  2:05 [PATCH] video: Add a callback 'notify_after' for backlight control dilee
2011-08-09  2:05 ` dilee
2011-08-09  2:05 ` dilee-DDmLM1+adcrQT0dZR+AlfA
     [not found] ` <1312855525-21464-1-git-send-email-dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-09  2:12   ` Robert Morell [this message]
2011-08-09  2:12     ` Robert Morell
2011-08-09  2:12     ` Robert Morell
2011-08-09  2:29 ` dilee
2011-08-09  2:29   ` dilee
2011-08-09  2:29   ` dilee-DDmLM1+adcrQT0dZR+AlfA
     [not found]   ` <1312856996-22452-1-git-send-email-dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-09  2:34     ` [PATCH] video: Add a callback 'notify_after' for backlight Robert Morell
2011-08-09  2:34       ` [PATCH] video: Add a callback 'notify_after' for backlight control Robert Morell
2011-08-09  2:34       ` Robert Morell
2011-08-09  3:43     ` [PATCH] video: Add a callback 'notify_after' for backlight Arun MURTHY
2011-08-09  3:43       ` [PATCH] video: Add a callback 'notify_after' for backlight control Arun MURTHY
2011-08-09  3:43       ` Arun MURTHY
2011-08-09  8:32 ` JinGoo Han
2011-08-09  8:32   ` JinGoo Han
2011-08-09  8:32   ` JinGoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110809021258.GM27748@morell.nvidia.com \
    --to=rmorell@nvidia.com \
    --cc=JNien-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=arun.murthy-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
    --cc=dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org \
    --cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
    --cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.