From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Konrad <konrad.wilk@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduce to shutdown watches from old kernel
Date: Tue, 9 Aug 2011 11:28:12 +0200 [thread overview]
Message-ID: <20110809092812.GA7283@aepfle.de> (raw)
In-Reply-To: <1312881318.26263.44.camel@zakaz.uk.xensource.com>
On Tue, Aug 09, Ian Campbell wrote:
> > +++ linux-3.0/drivers/xen/xenbus/xenbus_xs.c
> > + return xs_error(xs_talkv(XBT_NIL, XS_INTRODUCE, iov,
> > + ARRAY_SIZE(iov), NULL));
>
> What should we do if this fails?
There is not much other than printk and move on.
A kexec boot cant be detected from withing kexec.
> > + snprintf(domid, sizeof(domid), "%u", DOMID_SELF);
> > + snprintf(mfn, sizeof(mfn), "%lu", xen_store_mfn);
> > + snprintf(port, sizeof(port), "%d", xen_store_evtchn);
>
> These can be within the if, or better within the xs_introduce function
> itself.
Yes, thats true. I will rearrange the code.
Olaf
next prev parent reply other threads:[~2011-08-09 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 16:20 [PATCH 0/3] [v4] kexec and kdump for Xen PVonHVM guests Olaf Hering
2011-08-04 16:20 ` [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduce to shutdown watches from old kernel Olaf Hering
2011-08-09 9:15 ` [Xen-devel] " Ian Campbell
2011-08-09 9:15 ` Ian Campbell
2011-08-09 9:28 ` Olaf Hering [this message]
2011-08-04 16:20 ` [PATCH 2/3] xen/pv-on-hvm kexec: rebind virqs to existing eventchannel ports Olaf Hering
2011-08-09 9:17 ` [Xen-devel] " Ian Campbell
2011-08-09 9:29 ` Olaf Hering
2011-08-09 11:25 ` Ian Campbell
2011-08-09 15:28 ` Olaf Hering
2011-08-09 18:51 ` Konrad Rzeszutek Wilk
2011-08-04 16:20 ` [PATCH 3/3] xen/pv-on-hvm kexec+kdump: reset PV devices in kexec or crash kernel Olaf Hering
2011-08-09 9:23 ` [Xen-devel] " Ian Campbell
2011-08-09 9:44 ` Olaf Hering
2011-08-09 9:44 ` Olaf Hering
2011-08-09 11:26 ` [Xen-devel] " Ian Campbell
2011-08-09 19:02 ` [Xen-devel] [PATCH 0/3] [v4] kexec and kdump for Xen PVonHVM guests Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809092812.GA7283@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.