All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alon Levy <alevy@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/qxl: fir build break with newer spice
Date: Tue, 9 Aug 2011 19:26:53 +0300	[thread overview]
Message-ID: <20110809162653.GD3771@bow.redhat.com> (raw)
In-Reply-To: <1312892475-20237-1-git-send-email-alevy@redhat.com>

On Tue, Aug 09, 2011 at 03:21:15PM +0300, Alon Levy wrote:
> ioport_write's val was changed from uint32_t to uint64_t, this
> broke two printfs. Use PRId64 instead of %d.

Nack, missed a 'd' on the second fix. And the subject has a typo.

> 
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>  hw/qxl.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/qxl.c b/hw/qxl.c
> index db7ae7a..2335e4b 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -1189,7 +1189,7 @@ async_common:
>          }
>          d->current_async = orig_io_port;
>          qemu_mutex_unlock(&d->async_lock);
> -        dprint(d, 2, "start async %d (%d)\n", io_port, val);
> +        dprint(d, 2, "start async %d (%"PRId64")\n", io_port, val);
>          break;
>      default:
>          break;
> @@ -1305,7 +1305,8 @@ async_common:
>          break;
>      }
>      case QXL_IO_FLUSH_SURFACES_ASYNC:
> -        dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) (%s, s#=%d, res#=%d)\n",
> +        dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC"
> +                     " (%"PRId64"d) (%s, s#=%d, res#=%d)\n",
>                 val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
>                 d->num_free_res);
>          qxl_spice_flush_surfaces_async(d);
> -- 
> 1.7.6
> 
> 

      reply	other threads:[~2011-08-09 16:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 12:21 [Qemu-devel] [PATCH] hw/qxl: fir build break with newer spice Alon Levy
2011-08-09 16:26 ` Alon Levy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110809162653.GD3771@bow.redhat.com \
    --to=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.