From: Oleg Nesterov <oleg@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Aditya Kali <adityakali@google.com>
Subject: Re: [PATCH 7/8] cgroups: Add a task counter subsystem
Date: Tue, 9 Aug 2011 20:39:00 +0200 [thread overview]
Message-ID: <20110809183900.GA29472@redhat.com> (raw)
In-Reply-To: <20110809183402.GD31645@somewhere.redhat.com>
On 08/09, Frederic Weisbecker wrote:
>
> On Tue, Aug 09, 2011 at 08:19:47PM +0200, Oleg Nesterov wrote:
> >
> > Yes, but how this can help?
> >
> > ->attach_task() is called before cgroup_task_migrate(). Suppose
> > that it exits before ->attach_task(). In this case we shouldn't
> > uncharge the old cgroup, it was already uncharged by cgroup_exit.
>
> Yeah that's why in cgroup_attach_proc() we need to call cgroup_task_migrate()
> before ->attach_task(), as it's done in cgroup_attach_task().
Agreed. I do not undertand why attach task/proc should differ. This
doesn't look good even if (currently) correct.
> And also call
> cancel_attach_task() if it fails there with -ESRCH without cancelling
> the whole group attachment.
Probably... and attach_task() should do the same.
Oleg.
next prev parent reply other threads:[~2011-08-09 18:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 16:13 [PATCH 0/8 v3] cgroups: Task counter subsystem (was: New max number of tasks subsystem) Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 1/8] cgroups: Add res_counter_write_u64() API Frederic Weisbecker
2011-08-09 15:17 ` Oleg Nesterov
2011-08-09 17:31 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 2/8] cgroups: New resource counter inheritance API Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 3/8] cgroups: Add previous cgroup in can_attach_task/attach_task callbacks Frederic Weisbecker
2011-08-17 2:40 ` Li Zefan
2011-08-27 13:58 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 4/8] cgroups: New cancel_attach_task subsystem callback Frederic Weisbecker
2011-08-17 2:40 ` Li Zefan
2011-08-27 13:58 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 5/8] cgroups: Ability to stop res charge propagation on bounded ancestor Frederic Weisbecker
2011-08-17 2:41 ` Li Zefan
2011-08-27 13:59 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 6/8] cgroups: Add res counter common ancestor searching Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 7/8] cgroups: Add a task counter subsystem Frederic Weisbecker
2011-08-01 23:13 ` Andrew Morton
2011-08-04 14:05 ` Frederic Weisbecker
2011-08-09 15:11 ` Oleg Nesterov
2011-08-09 17:27 ` Frederic Weisbecker
2011-08-09 17:57 ` Oleg Nesterov
2011-08-09 18:09 ` Frederic Weisbecker
2011-08-09 18:19 ` Oleg Nesterov
2011-08-09 18:34 ` Frederic Weisbecker
2011-08-09 18:39 ` Oleg Nesterov [this message]
2011-08-17 3:18 ` Li Zefan
2011-08-27 14:16 ` Frederic Weisbecker
2011-07-29 16:13 ` [PATCH 8/8] res_counter: Allow charge failure pointer to be null Frederic Weisbecker
2011-08-17 2:44 ` Li Zefan
2011-08-27 14:05 ` Frederic Weisbecker
2011-08-01 23:19 ` [PATCH 0/8 v3] cgroups: Task counter subsystem (was: New max number of tasks subsystem) Andrew Morton
2011-08-03 14:29 ` Frederic Weisbecker
2011-08-12 21:11 ` Tim Hockin
2011-08-16 16:01 ` Kay Sievers
2011-08-18 14:33 ` [RFD] Task counter: cgroup core feature or cgroup subsystem? (was Re: [PATCH 0/8 v3] cgroups: Task counter subsystem) Frederic Weisbecker
2011-08-23 16:07 ` Paul Menage
2011-08-24 17:54 ` Frederic Weisbecker
2011-08-26 7:28 ` Li Zefan
2011-08-26 14:58 ` Paul Menage
2011-09-06 9:06 ` Li Zefan
2011-08-26 15:16 ` Paul Menage
2011-08-27 13:40 ` Frederic Weisbecker
2011-08-31 22:36 ` Paul Menage
2011-08-31 21:54 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809183900.GA29472@redhat.com \
--to=oleg@redhat.com \
--cc=adityakali@google.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.