All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM926ejs: Add routines to invalidate D-Cache
Date: Wed, 10 Aug 2011 04:46:26 +0200	[thread overview]
Message-ID: <201108100446.27178.marek.vasut@gmail.com> (raw)
In-Reply-To: <4E41E2A7.8080302@atmel.com>

On Wednesday, August 10, 2011 03:45:11 AM Hong Xu wrote:
> Hi Marek Vasut,
> 
> On 08/10/2011 03:55 AM, Marek Vasut wrote:
> > On Tuesday, August 09, 2011 03:57:41 AM Hong Xu wrote:
> >> Hi Marek Vasut,
> 
> >> On 08/09/2011 01:34 AM, Marek Vasut wrote:
> [...]
> 
> >>>>      printf("WARNING: %s - start address %x is not aligned\n"
> >>>>      
> >>>>        __FUNCTION__, start);
> >>> 
> >>> __func__ is prefered in linux kernel :-)
> >> 
> >> __func__ is C99 standard. __FUNCTION__ appears more in U-Boot. ;-)
> > 
> > This doesn't mean it's correct ;-) "majority proof" isn't a proof really.
> > 
> >> GCC manual says some older GCC only recognize __FUNCTION__ .
> >> If we rely on GCC, it looks __FUNCTION__ will reduce troubles.
> > 
> > Do we support such ancient versions of GCC anyway ? Just to be clear, I'm
> > fine with either way, just my 2.7183 cents ;-)
> 
> Agree. Just after last reply, I reconsidered the situation in the
> tearoom. __func__ looks better. ;-)  I'll resend the patch soon, thanks.

Thanks, I'm very much looking forward to this patch in mainline.
> 
> BR,
> Eric

  reply	other threads:[~2011-08-10  2:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08  3:20 [U-Boot] [PATCH] ARM926ejs: Add routines to invalidate D-Cache Hong Xu
2011-08-08  8:01 ` Albert ARIBAUD
2011-08-08  8:58   ` Hong Xu
2011-08-08 17:34   ` Marek Vasut
2011-08-08 17:56     ` Albert ARIBAUD
2011-08-09  1:57     ` Hong Xu
2011-08-09 19:55       ` Marek Vasut
2011-08-10  1:45         ` Hong Xu
2011-08-10  2:46           ` Marek Vasut [this message]
2011-08-09 11:05     ` Aneesh V
  -- strict thread matches above, loose matches on Subject: below --
2011-08-04  3:45 Hong Xu
2011-08-04  7:11 ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108100446.27178.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.