From mboxrd@z Thu Jan  1 00:00:00 1970
From: walimis <walimisdev@gmail.com>
Subject: Re: [PATCH 2/2] kvm tools: handle failure of command
Date: Wed, 10 Aug 2011 13:33:04 +0800
Message-ID: <20110810053304.GC16258@walimis-desktop>
References: <1312944249-4946-1-git-send-email-walimisdev@gmail.com>
 <1312944249-4946-2-git-send-email-walimisdev@gmail.com>
 <CAOJsxLEJ=62T=gh=QLahaiC=JM0-SvRLUJN5DQB-tjZ3N=CU7g@mail.gmail.com>
 <20110810050340.GB16258@walimis-desktop>
 <4E42176B.7000701@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	Sasha Levin <levinsasha928@gmail.com>,
	Prasad Joshi <prasadjoshi124@gmail.com>,
	Asias He <asias.hejun@gmail.com>, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-iy0-f170.google.com ([209.85.210.170]:44099 "EHLO
	mail-iy0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751062Ab1HJFtR (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 10 Aug 2011 01:49:17 -0400
Received: by iye16 with SMTP id 16so519932iye.1
        for <kvm@vger.kernel.org>; Tue, 09 Aug 2011 22:49:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4E42176B.7000701@kernel.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Aug 10, 2011 at 08:30:19AM +0300, Pekka Enberg wrote:
>On 8/10/11 8:03 AM, walimis wrote:
>>On Wed, Aug 10, 2011 at 08:02:01AM +0300, Pekka Enberg wrote:
>>>On Wed, Aug 10, 2011 at 5:44 AM, Liming Wang<walimisdev@gmail.com>  wrote:
>>>>handle failure of calling command function, especially, only handle
>>>>EPERM error now.
>>>>
>>>>Signed-off-by: Liming Wang<walimisdev@gmail.com>
>>>I applied the patch because I absolutely loved the error handling
>>>cleanups from the previous patch. However, out of curiosity, are you
>>>seeing EPERM with some command in particular?
>>Yes. Because I'm using ubuntu and if I don't use sudo to execute
>>"kvm pause", pause command can't work and doesn't prompt anything.
>
>That's odd. I don't use sudo with the tool either. Sasha?
If I don't use sudo to run "kvm run", kvm prompt me:
  Fatal, could not open /dev/kvm: Permission denied

So I use sudo to execute "kvm run".
>>BTW, do you always login as "root" user?
>
>Depends on which image you're using.
I don't refer to the guest image. I mean that in your host PC, which user
you login and operate as.

walimis
>
>                            Pekka