All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Ric Wheeler <ricwheeler@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-ext4@vger.kernel.org
Subject: Re: Feature request: e2fsck -z
Date: Wed, 10 Aug 2011 09:25:26 -0400	[thread overview]
Message-ID: <20110810132526.GA726@thunk.org> (raw)
In-Reply-To: <4E422686.8080207@gmail.com>

On Wed, Aug 10, 2011 at 07:34:46AM +0100, Ric Wheeler wrote:
> 
> Do you need it to be in the fsck tool?

As others have noted, (a) zerofree does this already, and (b) there's
also -E discard.

My take on it though is that it's a reasonable request.  It's much
like there is "sort -u" even though you could do this via "sort |
uniq".  Part of the Unix philosophy is to use tools that are
composable, yes --- but optimizing for common cases is also a good
thing, and with the advent of virtualization being more and more
popular, zeroing free blocks for virtualization images is good and
useful thing.

This is also why I agitated for adding support so that e2fsprogs tools
could operate directly on qemu-img files, and not just have support
which is hacked into e2image.  Yes, you can always take an qemu-img
file, decompress and expand it into a raw file, run debugfs or e2fsck
on it, and then convert it back to a qemu-img file --- but if lots of
people are doing that, it does make sense to optimize for the most
common use cases.

						- Ted

  parent reply	other threads:[~2011-08-10 13:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 17:52 Feature request: e2fsck -z H. Peter Anvin
2011-08-10  6:34 ` Ric Wheeler
2011-08-10  8:16   ` Andreas Dilger
2011-08-10  8:22     ` Ric Wheeler
2011-08-10  9:35       ` Lukas Czerner
2011-08-10 10:55         ` Florian Weimer
2011-08-10 11:01           ` Lukas Czerner
2011-08-10 11:04             ` Florian Weimer
2011-08-10 11:06               ` Ric Wheeler
2011-08-10 11:09               ` Lukas Czerner
2011-08-10 13:25   ` Ted Ts'o [this message]
2011-08-10 14:34     ` Lukas Czerner
2011-08-10  7:54 ` Ron Yorston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810132526.GA726@thunk.org \
    --to=tytso@mit.edu \
    --cc=hpa@zytor.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ricwheeler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.