From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David Evensky" Subject: Re: [PATCH] kvm tools: Use correct size for VESA memory BAR Date: Wed, 10 Aug 2011 10:46:09 -0700 Message-ID: <20110810174609.GA3663@dancer.ca.sandia.gov> References: <1312903262-8212-1-git-send-email-levinsasha928@gmail.com> <20110809153912.GB7867@elte.hu> <4E416449.5020205@redhat.com> <4E42218F.4050705@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: "Avi Kivity" , "Ingo Molnar" , "Sasha Levin" , asias.hejun@gmail.com, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org To: "Pekka Enberg" Return-path: Received: from sentry-two.sandia.gov ([132.175.109.14]:49939 "EHLO sentry-two.sandia.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754464Ab1HJRqe (ORCPT ); Wed, 10 Aug 2011 13:46:34 -0400 In-Reply-To: <4E42218F.4050705@kernel.org> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: I don't know if there were any other drivers for this patch, but it along with another patch (maybe integrated elsewhere for 32bit BAR vs 8bit) certainly helped me out a lot. These patches fixed ioremap errors I was seeing (I had a 16MB PCI memory region, but it appeared to be only 256 bytes in size; the kernel complained bitterly about that on ioremap). It also was an issue of expected vs unexpected output from lspci -vvv. I'm working on my out-of-tree PCI driver to see if it can become in tree. I have more cleanup to do, and seeing how close I can come to the target coding standards. \dae On Wed, Aug 10, 2011 at 09:13:35AM +0300, Pekka Enberg wrote: > On 8/9/11 7:46 PM, Avi Kivity wrote: > >On 08/09/2011 06:39 PM, Ingo Molnar wrote: > >>* Sasha Levin wrote: > >> > >>> This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar. > >>> > >> > >>This changelog is missing some key information: > >> > >> - how did you find the bug (by chance via code review or did you see > >> some actual badness?) > >> > >> - what practical effect (if any) did you see from this patch? > >> > >> - what practical effect (if any) do you expect others to see > >>from this patch? > >> > >>I suspect this patch is only for completeness/correctness but has no > >>practical effect - but that's a guess. > >> > > > >My guess would be that seabios tried to lay out the BARs and had > >trouble fitting a 16k pio bar in the small PCI pio region. > > Sasha? IIRC this fixed some issue with David's out-of-tree PCI driver?