All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH mainline] xen: xen-selfballoon.c needs more header files
Date: Wed, 10 Aug 2011 15:20:21 -0400	[thread overview]
Message-ID: <20110810192021.GA26264@dumpdata.com> (raw)
In-Reply-To: <20110810112242.18b743de.rdunlap@xenotime.net>

On Wed, Aug 10, 2011 at 11:22:42AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix build errors (found when CONFIG_SYSFS is not enabled):
> 
> drivers/xen/xen-selfballoon.c:446: warning: data definition has no type or storage class
> drivers/xen/xen-selfballoon.c:446: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> drivers/xen/xen-selfballoon.c:446: warning: parameter names (without types) in function declaration
> drivers/xen/xen-selfballoon.c:485: error: expected declaration specifiers or '...' before string constant
> drivers/xen/xen-selfballoon.c:485: warning: data definition has no type or storage class
> drivers/xen/xen-selfballoon.c:485: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/xen/xen-selfballoon.c:485: warning: function declaration isn't a prototype
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>

Ok, will stick it on my linux-next. Thanks!
> ---
>  drivers/xen/xen-selfballoon.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> and will need <linux/export.h> when module.h is split up.
> 
> --- lnx-31-rc1.orig/drivers/xen/xen-selfballoon.c
> +++ lnx-31-rc1/drivers/xen/xen-selfballoon.c
> @@ -70,6 +70,7 @@
>  #include <linux/kernel.h>
>  #include <linux/mm.h>
>  #include <linux/mman.h>
> +#include <linux/module.h>
>  #include <linux/workqueue.h>
>  #include <xen/balloon.h>
>  #include <xen/tmem.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2011-08-10 19:20 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08  2:25 Linux 3.1-rc1 Linus Torvalds
2011-08-08 20:59 ` Linux 3.1-rc1 (i7core_edac build error) Randy Dunlap
2011-08-08 21:31   ` Borislav Petkov
2011-08-08 21:37     ` Randy Dunlap
2011-08-09 10:01     ` Mauro Carvalho Chehab
2011-08-10 12:43       ` [PATCH] EDAC: Correct Kconfig dependencies Borislav Petkov
2011-08-10 17:14         ` Randy Dunlap
2011-08-11 16:26           ` Borislav Petkov
2011-08-08 21:35 ` Linux 3.1-rc1 (staging/comedi) Randy Dunlap
2011-08-08 21:37   ` Randy Dunlap
2011-08-08 21:51   ` Greg KH
2011-08-08 23:32     ` Randy Dunlap
2011-08-10 18:22 ` [PATCH mainline] xen: xen-selfballoon.c needs more header files Randy Dunlap
2011-08-10 19:20   ` Konrad Rzeszutek Wilk [this message]
2011-08-10 19:23 ` Linux 3.1-rc1 (nfs/pnfs and drivers/md) Randy Dunlap
2011-08-11  0:35   ` Peng Tao
2011-08-11  0:35     ` Peng Tao
2011-08-11  0:58     ` Randy Dunlap
2011-08-11  1:10       ` Linus Torvalds
2011-08-11  1:10         ` Linus Torvalds
2011-08-11  3:26         ` tao.peng
2011-08-11  3:26           ` tao.peng-mb1K0bWo544
2011-08-11  6:06           ` Christoph Hellwig
2011-08-11  6:21             ` tao.peng
2011-08-11  6:21               ` tao.peng-mb1K0bWo544
2011-08-11 10:11           ` Benny Halevy
2011-08-11 10:11             ` Benny Halevy
2011-08-11 18:44             ` Boaz Harrosh
2011-08-11 18:44               ` Boaz Harrosh
2011-08-11 21:10               ` [PATCH] pnfs: Automatically select blocks & objects layouts Boaz Harrosh
2011-08-11 21:10                 ` Boaz Harrosh
2011-08-11 21:29                 ` [PATCH v2] " Boaz Harrosh
2011-08-11 21:29                   ` Boaz Harrosh
2011-08-11 21:43                   ` Randy Dunlap
2011-08-11 21:43                     ` Randy Dunlap
2011-08-11 21:53                     ` Boaz Harrosh
2011-08-11 21:53                       ` Boaz Harrosh
2011-08-11 22:13                 ` [PATCH] " Jim Rees
2011-08-11 22:13                   ` Jim Rees
2011-08-11 23:47                   ` Peng Tao
2011-08-11 23:47                     ` Peng Tao
2011-08-11 15:41           ` Linux 3.1-rc1 (nfs/pnfs and drivers/md) Randy Dunlap
2011-08-11 15:41             ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810192021.GA26264@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.