From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: EDAC: Correct Kconfig dependencies
Date: Wed, 10 Aug 2011 18:38:16 -0400 [thread overview]
Message-ID: <20110810223816.GA28802@redhat.com> (raw)
In-Reply-To: <201108101859.p7AIx1tU027687@hera.kernel.org>
On Wed, Aug 10, 2011 at 06:59:01PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/af9d220bac41dc3201893e1601cc7c44f7da4498
> Commit: af9d220bac41dc3201893e1601cc7c44f7da4498
> Parent: f2c0d0266cc5eb36a4aa44944b4096ec121490aa
> Author: Borislav Petkov <borislav.petkov@amd.com>
> AuthorDate: Wed Aug 10 14:43:30 2011 +0200
> Committer: Linus Torvalds <torvalds@linux-foundation.org>
> CommitDate: Wed Aug 10 10:57:42 2011 -0700
>
> EDAC: Correct Kconfig dependencies
>
> Both AMD and Intel i7 EDAC drivers use MCE features and are thus
> dependent of this functionality present in the kernel. Express this in
> Kconfig so that randconfig builds don't break.
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit broke the build for me..
drivers/edac/i7core_edac.c:259:18: error: field ‘edac_mce’ has incomplete type
drivers/edac/i7core_edac.c:262:23: error: ‘MCE_LOG_LEN’ undeclared here (not in a function)
drivers/edac/i7core_edac.c: In function ‘i7core_mce_output_error’:
drivers/edac/i7core_edac.c:1671:25: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1672:20: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1673:23: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1674:15: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1675:18: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1676:18: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1680:7: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1742:22: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1742:31: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1743:39: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1744:15: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1751:7: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_check_error’:
drivers/edac/i7core_edac.c:1787:50: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1791:3: error: invalid use of undefined type ‘struct mce’
drivers/edac/i7core_edac.c:1793:49: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_mce_check_error’:
drivers/edac/i7core_edac.c:1838:11: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1842:9: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1847:293: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1859:52: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1864:9: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_unregister_mci’:
drivers/edac/i7core_edac.c:1910:2: error: implicit declaration of function ‘edac_mce_unregister’ [-Werror=implicit-function-declaration]
drivers/edac/i7core_edac.c: In function ‘i7core_register_mci’:
drivers/edac/i7core_edac.c:2008:2: error: implicit declaration of function ‘edac_mce_register’ [-Werror=implicit-function-declaration]
it needs at least to include asm/mce.h for all the missing types, but the bigger problem
is that CONFIG_EDAC_MCE not being select'd means that we never build edac_mce.o
(it's an unselectable bool in drivers/edac/Kconfig)
Dave
next parent reply other threads:[~2011-08-10 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201108101859.p7AIx1tU027687@hera.kernel.org>
2011-08-10 22:38 ` Dave Jones [this message]
2011-08-10 23:35 ` EDAC: Correct Kconfig dependencies Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810223816.GA28802@redhat.com \
--to=davej@redhat.com \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.