From: Lon Hohberger <lhh@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
Date: Wed, 10 Aug 2011 20:44:26 -0400 [thread overview]
Message-ID: <20110811004425.GE32361@redhat.com> (raw)
In-Reply-To: <4E42CA38.607@redhat.com>
On Wed, Aug 10, 2011 at 01:13:12PM -0500, Chris Feist wrote:
> Patch to fix common rgmanager scripts for use with pacemaker.
Oops... NACK
> 12 files changed, 53 insertions(+), 11 deletions(-)
> mode change 100644 => 100755 rgmanager/src/resources/apache.sh
> mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
> mode change 100644 => 100755 rgmanager/src/resources/ip.sh
> mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
> mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
> mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
> mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
> mode change 100644 => 100755 rgmanager/src/resources/utils/httpd-parse-config.pl
Modes didn't need to be changed.
> + clog_service_status $CLOG_FAILED "$APAHCE_pid_file"
Typo ... APACHE
> status_check_pid "$MYSQL_pid_file"
> + case $? in
> + $OCF_NOT_RUNNING)
> + clog_service_status $CLOG_FAILED "$MYSL_pid_file"
Typo ... MYSQL (happens twice in your patch)
Otherwise, good by me.
--
Lon Hohberger - Red Hat, Inc.
next prev parent reply other threads:[~2011-08-11 0:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 18:13 [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager Chris Feist
2011-08-11 0:44 ` Lon Hohberger [this message]
2011-08-11 2:28 ` Chris Feist
2011-08-11 2:56 ` Chris Feist
2011-08-12 1:18 ` Lon Hohberger
2011-08-11 3:57 ` Fabio M. Di Nitto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811004425.GE32361@redhat.com \
--to=lhh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.