All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Zhang Jiejing <jiejing.zhang@freescale.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, dima@android.com, kzjeef@gmail.com
Subject: Re: [PATCH v2] input: add EETI eGalax I2C capacitive multi touch driver.
Date: Thu, 11 Aug 2011 22:34:49 +0200	[thread overview]
Message-ID: <20110811203449.GA6162@polaris.bitmath.org> (raw)
In-Reply-To: <1312370963-24965-1-git-send-email-jiejing.zhang@freescale.com>

Hi Zhang,

> This is the patch after change to mt Protocol-B.
> but I have a issue with test tool, in the orignal patch, I use
> android to do the test, but android still not support Protocol B.

The device seems to send finger changes sequentually, resulting in one
packet (terminated with input sync) for each finger change. Is this
the intention/necessary? Some egalax firmware (hid version) seems to
work this way.

The usage of REPORT_MODE_* is unclear to me too.

Other than that, the patch looks nice (at first glance).

Thanks,
Henrik

  parent reply	other threads:[~2011-08-11 20:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26  9:25 [PATCH] input: add EETI eGalax I2C capacitive multi touch driver Zhang Jiejing
2011-07-26  9:47 ` Wanlong Gao
2011-07-29  5:28   ` Jiejing.Zhang 
2011-07-29  6:00     ` Wanlong Gao
2011-08-01  6:34 ` Dmitry Torokhov
2011-08-02  8:49   ` Jiejing.Zhang 
2011-08-03 11:29   ` [PATCH v2] " Zhang Jiejing
2011-08-03 20:48     ` Chase Douglas
2011-08-04  0:19     ` Wanlong Gao
2011-08-11 20:34     ` Henrik Rydberg [this message]
2011-08-12 13:24       ` Jiejing.Zhang 
2011-08-12 20:30         ` Henrik Rydberg
2011-09-08 11:39           ` Jiejing.Zhang 
2011-09-08 11:40           ` [PATCH] " Zhang Jiejing
2011-09-13  9:15             ` Henrik Rydberg
2011-09-14  4:50               ` Jiejing.Zhang 
2011-09-14  4:57                 ` Dmitry Torokhov
2011-11-10 10:01                 ` [PATCH V3] " Zhang Jiejing
2011-11-10 18:38                   ` Dmitry Torokhov
2011-11-12  6:12                     ` [PATCH V4] " Zhang Jiejing
2011-11-12  8:02                       ` Dmitry Torokhov
2011-11-12  8:45                         ` Jiejing Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110811203449.GA6162@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=dima@android.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jiejing.zhang@freescale.com \
    --cc=kzjeef@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.