diff for duplicates of <20110812065858.GA6916@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 4c8a4bb..16a3213 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ On Fri, Aug 12, 2011 at 08:44:34AM +0900, Minchan Kim wrote: > > regularly calculated scan numbers turned out zero. > > > > However, the effective scan number can always be assumed to be -> > SWAP_CLUSTER_MAX right before the division into anon and file. The +> > SWAP_CLUSTER_MAX right before the division into anon and file. The > > numerators and denominator are properly set up for all cases, be it > > force scan for just file, just anon, or both, to do the right thing. > > @@ -18,23 +18,23 @@ Thanks. > There is a nitpick at below. > > @@ -1927,20 +1917,10 @@ out: -> > scan = zone_nr_lru_pages(zone, sc, l); -> > if (priority || noswap) { -> > scan >>= priority; -> > + if (!scan && force_scan) -> > + scan = SWAP_CLUSTER_MAX; -> > scan = div64_u64(scan * fraction[file], denominator); -> > } +> > scan = zone_nr_lru_pages(zone, sc, l); +> > if (priority || noswap) { +> > scan >>= priority; +> > + if (!scan && force_scan) +> > + scan = SWAP_CLUSTER_MAX; +> > scan = div64_u64(scan * fraction[file], denominator); +> > } > > - -> > - /* -> > - * If zone is small or memcg is small, nr[l] can be 0. -> > - * This results no-scan on this priority and priority drop down. -> > - * For global direct reclaim, it can visit next zone and tend -> > - * not to have problems. For global kswapd, it's for zone -> > - * balancing and it need to scan a small amounts. When using -> > - * memcg, priority drop can cause big latency. So, it's better -> > - * to scan small amount. See may_noscan above. -> > - */ +> > - /* +> > - * If zone is small or memcg is small, nr[l] can be 0. +> > - * This results no-scan on this priority and priority drop down. +> > - * For global direct reclaim, it can visit next zone and tend +> > - * not to have problems. For global kswapd, it's for zone +> > - * balancing and it need to scan a small amounts. When using +> > - * memcg, priority drop can cause big latency. So, it's better +> > - * to scan small amount. See may_noscan above. +> > - */ > > Please move this comment with tidy-up at where making force_scan true. > Of course, we can find it by git log[246e87a9393] but as I looked the @@ -153,3 +153,10 @@ index 96061d7..a6ca076 100644 } -- 1.7.6 + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index e5b0e26..6e62a5f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -24,7 +24,7 @@ "> > regularly calculated scan numbers turned out zero.\n" "> >\n" "> > However, the effective scan number can always be assumed to be\n" - "> > SWAP_CLUSTER_MAX right before the division into anon and file. \302\240The\n" + "> > SWAP_CLUSTER_MAX right before the division into anon and file. The\n" "> > numerators and denominator are properly set up for all cases, be it\n" "> > force scan for just file, just anon, or both, to do the right thing.\n" "> >\n" @@ -37,23 +37,23 @@ "> There is a nitpick at below.\n" "\n" "> > @@ -1927,20 +1917,10 @@ out:\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240scan = zone_nr_lru_pages(zone, sc, l);\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240if (priority || noswap) {\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240scan >>= priority;\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (!scan && force_scan)\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 scan = SWAP_CLUSTER_MAX;\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240scan = div64_u64(scan * fraction[file], denominator);\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240}\n" + "> > scan = zone_nr_lru_pages(zone, sc, l);\n" + "> > if (priority || noswap) {\n" + "> > scan >>= priority;\n" + "> > + if (!scan && force_scan)\n" + "> > + scan = SWAP_CLUSTER_MAX;\n" + "> > scan = div64_u64(scan * fraction[file], denominator);\n" + "> > }\n" "> > -\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 /*\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* If zone is small or memcg is small, nr[l] can be 0.\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* This results no-scan on this priority and priority drop down.\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* For global direct reclaim, it can visit next zone and tend\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* not to have problems. For global kswapd, it's for zone\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* balancing and it need to scan a small amounts. When using\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* memcg, priority drop can cause big latency. So, it's better\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* to scan small amount. See may_noscan above.\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240*/\n" + "> > - /*\n" + "> > - * If zone is small or memcg is small, nr[l] can be 0.\n" + "> > - * This results no-scan on this priority and priority drop down.\n" + "> > - * For global direct reclaim, it can visit next zone and tend\n" + "> > - * not to have problems. For global kswapd, it's for zone\n" + "> > - * balancing and it need to scan a small amounts. When using\n" + "> > - * memcg, priority drop can cause big latency. So, it's better\n" + "> > - * to scan small amount. See may_noscan above.\n" + "> > - */\n" "> \n" "> Please move this comment with tidy-up at where making force_scan true.\n" "> Of course, we can find it by git log[246e87a9393] but as I looked the\n" @@ -171,6 +171,13 @@ " \t}\n" " }\n" "-- \n" - 1.7.6 + "1.7.6\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -edfd9136fb7dc7ca149914ce34dc633bf029e50a282c9ab5c029a6e6814f5019 +bcbbc79d3f8712aa3cd983c48fd159c6a00f55ad1056139565175576928caae4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.