Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address

["John W. Linville" <linville@tuxdriver.com>]

On Wed, Aug 10, 2011 at 12:14:16AM +0530, Senthil Balasubramanian wrote:
> On Tue, Aug 09, 2011 at 11:32:17AM -0700, Luis R. Rodriguez wrote:
> > On Tue, Aug 9, 2011 at 11:31 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > > On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian
> > > <senthilb@qca.qualcomm.com> wrote:
> > >> Due to some recent optimization done in the way the mac address
> > >> bytes are written into the OTP memory, some AR9485 chipsets were
> > >> forced to use the first byte from the eeprom template and as AR9485
> > >> happens to use generic eeprom template which has 0x1 as the first
> > >> byte causes issues in bringing up the card.
> > >>
> > >> So fixed the eeprom template accordingly to address the issue.
> > >>
> > >> Cc: Paul Stewart <pstew@google.com>
> > >> Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
> > >
> > > I don't follow the description too well, all I can tell from it is
> > > that there is an issue if the template has 0x01 set instead of 0x0 but
> > > it doesn't tell me why.
> The leading byte is 1 which is obviously incorrect for mac address.
> The reason why 1 is chosen by the driver for mac address is due to
> the way the OTP write was optimized and so the driver has taken the
> first byte alone from the template and the remaining from OTP.
> 
> > 
> > Is this not a stable fix?
> Oops.. Yes it is. Let me cc to stable. thanks for the stable reminder :-(

Are you goint to resubmit a patch w/ a better changelog and
Cc: stable@kernel.org?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.