From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linus <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] regmap: using module facilities requires module.h
Date: Tue, 16 Aug 2011 09:06:26 +0100 [thread overview]
Message-ID: <20110816080626.GA15093@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110815234106.GB14003@opensource.wolfsonmicro.com>
On Tue, Aug 16, 2011 at 08:41:06AM +0900, Mark Brown wrote:
> On Tue, Aug 16, 2011 at 09:36:06AM +1000, Stephen Rothwell wrote:
> > Commit b33f9cbd67ba ("regmap: Specify a module license") added a
> > MODULES_LICENSE to this file without adding an include of module.h.
> > module.h should ahve been included anyway, since this file has
> > EXPORT_SYMBOLs as well. With the pending module.h spliit up, this would
> > probably caused build problems.
> Applied with a few typo fixes to the commit log, thanks.
...and backed out again as Linus applied directly anyway (with the same
typo fixes).
prev parent reply other threads:[~2011-08-16 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 23:36 [PATCH] regmap: using module facilities requires module.h Stephen Rothwell
2011-08-15 23:41 ` Mark Brown
2011-08-16 8:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816080626.GA15093@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=swarren@nvidia.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.