From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Pavel Roskin <proski@gnu.org>
Cc: David Rientjes <rientjes@google.com>, linux-kernel@vger.kernel.org
Subject: Re: Suppressing a plus from setlocalversion
Date: Tue, 16 Aug 2011 15:24:58 +0200 [thread overview]
Message-ID: <20110816152458.71b0bd74@stein> (raw)
In-Reply-To: <20110815222141.jgw2q59rko0wssoc-cebfxv@webmail.spamcop.net>
On Aug 15 Pavel Roskin wrote:
> Quoting David Rientjes <rientjes@google.com>:
>
> > On Mon, 15 Aug 2011, Pavel Roskin wrote:
> >
> >> Hello!
> >>
> >> There is one annoyance in the build system that I cannot work around.
> >
> > That's surprising since you actually state the workaround, i.e. using
> > LOCALVERSION= with make, yourself.
>
> OK, I don't consider that an acceptable solution, as it could
> interfere with other build systems.
>
> However, as soon as I posted this message, I found a better solution,
> namely setting LOCALVERSION= in the environment (both for the normal
> user and for root). This is less likely to have unexpected effects,
> since the environment variables don't override the variables
> explicitly set in makefiles.
Having this globally as an environment variable seems to be a more
intrusive alternative; there are no namespaces.
You can wrap the make command lines that you often use into shell
aliases. I often use command lines like 'nice make -j8' or
'nice make -j8 C=1 CF="-D__CHECK_ENDIAN__"' by alias.
> > Yes, because the kernel you've produced is no longer 3.1.0-rc2, it is
> > modified. If you want to do something else locally, then you can always
> > use LOCALVERSION=.
> >
> > The + was added to stop falsely identifying kernels as a specific version
> > when they are modified by default. Sorry if you forget to override it
> > sometimes.
I for one am glad that I don't have to remember to force a localversion
all the time. All of the kernels that I runtime-test have their source
managed by quilt, not git. Thankfully, scripts/setlocalversion
acknowledges that quilt users know what they are doing. :-)
--
Stefan Richter
-=====-==-== =--- =----
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-08-16 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 21:37 Suppressing a plus from setlocalversion Pavel Roskin
2011-08-15 23:06 ` David Rientjes
2011-08-16 2:21 ` Pavel Roskin
2011-08-16 13:24 ` Stefan Richter [this message]
2011-08-16 15:35 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816152458.71b0bd74@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.