From: Arnd Bergmann <arnd@arndb.de>
To: Jamie Iles <jamie@jamieiles.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/5] Remove UPIO_DWAPB{,32} from 8250 driver
Date: Tue, 16 Aug 2011 16:05:08 +0200 [thread overview]
Message-ID: <201108161605.08811.arnd@arndb.de> (raw)
In-Reply-To: <1313399875-11006-1-git-send-email-jamie@jamieiles.com>
On Monday 15 August 2011, Jamie Iles wrote:
>
> This is just a repost of a series from a couple of months ago to remove
> the special DWAPB 8250 handling from the generic driver.
>
> Arnd, I'd have a platform that needs some special handlers like these
> using the device tree and of_serial. Once these are merged I plan on
> passing the serial_{in,out} and handle_irq callbacks through
> platform_data to of_serial. Does this seem sensible?
Do you mean passing through the uart_port? Yes, that seems sensible.
Depending on how complicated the callbacks are, it might be
simpler to write a new platform_driver based on of_serial.c for
your device that hardcodes these.
The of_serial driver started out with the goal of covering all sorts
of serial port devices based on device tree probing, but with the
direction that the platform drivers have moved to, this seems a bit
silly, and I think we should take the NWPSERIAL support out and
rename it to 8250_of.c.
Arnd
next prev parent reply other threads:[~2011-08-16 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 9:17 [PATCH 0/5] Remove UPIO_DWAPB{,32} from 8250 driver Jamie Iles
2011-08-15 9:17 ` [PATCH 1/5] tty: serial: allow ports to override the irq handler Jamie Iles
2011-08-15 9:17 ` [PATCH 2/5] tty: serial8250: allow platforms to override " Jamie Iles
2011-08-15 9:17 ` [PATCH 3/5] mips: msp71xx/serial: convert to pr_foo() helpers Jamie Iles
2011-08-15 12:44 ` Ralf Baechle
2011-08-15 12:47 ` Ralf Baechle
2011-08-18 18:40 ` Anoop P.A.
2011-08-15 9:17 ` [PATCH 4/5] mips: msp71xx/serial: add workaround for DW UART Jamie Iles
2011-08-17 12:56 ` Ralf Baechle
2011-08-17 13:51 ` Jamie Iles
2011-08-15 9:17 ` [PATCH 5/5] tty: serial8250: remove UPIO_DWAPB{,32} Jamie Iles
2011-08-15 9:34 ` [PATCH 0/5] Remove UPIO_DWAPB{,32} from 8250 driver Alan Cox
2011-08-16 14:05 ` Arnd Bergmann [this message]
2011-08-16 14:20 ` Jamie Iles
2011-08-16 14:39 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2011-06-16 9:19 Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108161605.08811.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jamie@jamieiles.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.