All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] openwrt lib/batman-adv/config.sh
Date: Tue, 16 Aug 2011 17:30:02 +0200	[thread overview]
Message-ID: <201108161730.03159.lindner_marek@yahoo.de> (raw)
In-Reply-To: <CAFevQmMrBa20As8dAEoMCiWqUUm+xxS0=GGex5orx6=seKfmbQ@mail.gmail.com>


Hi,

> In this mail you can find batman-adv initscript updated to work in
> this way and the batman-adv library file that must be located in
> /lib/batman-adv/.

I liked the idea of having hotplug hooks to restart the batman-adv 
configuration automatically. 
Generally, the scripts look good to me. You also changed its "coding style", 
e.g. $var -> ${var}. This does not look very OpenWRT-ish, therefore I would 
prefer keeping the current style. Any objections ?

Regards,
Marek

  reply	other threads:[~2011-08-16 15:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.52.1312816695.1125.b.a.t.m.a.n@lists.open-mesh.org>
     [not found] ` <CAFevQmMWGcJhzKiZzDKOh_pMAq1CyMJrPh=FMpYAQh-wXZwH=g@mail.gmail.com>
2011-08-16 10:58   ` [B.A.T.M.A.N.] openwrt lib/batman-adv/config.sh Filippo Sallemi
2011-08-16 15:30     ` Marek Lindner [this message]
2011-08-17  4:54       ` Filippo Sallemi
2011-08-21 23:46         ` Marek Lindner
2011-08-24 11:50           ` Filippo Sallemi
2011-09-12 17:43             ` Filippo Sallemi
2011-10-30 21:36               ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108161730.03159.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.