All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	shemminger@linux-foundation.org, eric.dumazet@gmail.com,
	kaber@trash.net, yoshfuji@linux-ipv6.org, rdunlap@xenotime.net,
	kuznet@ms2.inr.ac.ru, jmorris@namei.org, mirqus@gmail.com,
	jesse@nicira.com
Subject: Re: [patch net-next-2.6 2/3] net: remove use of ndo_set_multicast_list in drivers
Date: Tue, 16 Aug 2011 22:07:45 +0200	[thread overview]
Message-ID: <20110816200744.GA1971@minipsycho> (raw)
In-Reply-To: <1313520028.2725.35.camel@bwh-desktop>

Tue, Aug 16, 2011 at 08:40:28PM CEST, bhutchings@solarflare.com wrote:
>On Tue, 2011-08-16 at 18:29 +0200, Jiri Pirko wrote:
>> replace it by ndo_set_rx_mode
>[...]
>
>Shouldn't this also rename the implementations whose names include
>'multicast'?

I was thinking about that. But sometimes it's not absolutelly trivial.
Also, I think that perserving the existing names would cause any
troubles so I left that as it is. Feel free to do incremental patch :)

>
>Ben.
>
>-- 
>Ben Hutchings, Staff Engineer, Solarflare
>Not speaking for my employer; that's the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.
>

  reply	other threads:[~2011-08-16 20:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16 16:28 [patch net-next-2.6 0/3] net: remove ndo_set_multicast_list Jiri Pirko
2011-08-16 16:29 ` [patch net-next-2.6 1/3] net: introduce IFF_UNICAST_FLT private flag Jiri Pirko
2011-08-16 16:29 ` [patch net-next-2.6 2/3] net: remove use of ndo_set_multicast_list in drivers Jiri Pirko
2011-08-16 18:40   ` Ben Hutchings
2011-08-16 20:07     ` Jiri Pirko [this message]
2011-08-16 16:29 ` [patch net-next-2.6 3/3] net: remove ndo_set_multicast_list callback Jiri Pirko
2011-08-18  3:22 ` [patch net-next-2.6 0/3] net: remove ndo_set_multicast_list David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110816200744.GA1971@minipsycho \
    --to=jpirko@redhat.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jesse@nicira.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=mirqus@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=shemminger@linux-foundation.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.