From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: Fix check for symmetric rate enforcement Date: Wed, 17 Aug 2011 15:50:16 +0900 Message-ID: <20110817065014.GB12344@opensource.wolfsonmicro.com> References: <20110817062753.GB31404@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 9D7D11038BC for ; Wed, 17 Aug 2011 08:50:25 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20110817062753.GB31404@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Sascha Hauer Cc: alsa-devel@alsa-project.org, Liam Girdwood , Lambrecht =?iso-8859-1?Q?J=FCrgen?= List-Id: alsa-devel@alsa-project.org On Wed, Aug 17, 2011 at 08:27:53AM +0200, Sascha Hauer wrote: > The ASoC core tries to not enforce symmetric rates when > two streams open simultaneously. It does so by checking > rtd->rate being zero. This works exactly once after booting > because it is not set to zero again when the streams close. > Fix this by clearing rtd->rate when no active stream is left. > Signed-off-by: Sascha Hauer Applied, thanks. Though I suspect that in practice this may actually be less robust due to the general raciness of the way we configure and start the streams - I seem to recall the code works this way semi deliberately so that we always have a rate selected; most systems only ever use one rate on symmetric audio interfaces.