From: Oleg Nesterov <oleg@redhat.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/41] signal: Use set_current_blocked()
Date: Thu, 18 Aug 2011 20:36:59 +0200 [thread overview]
Message-ID: <20110818183659.GA10353@redhat.com> (raw)
In-Reply-To: <1313665755.2311.57.camel@mfleming-mobl1.ger.corp.intel.com>
On 08/18, Matt Fleming wrote:
>
> On Wed, 2011-08-17 at 23:17 +0100, Matt Fleming wrote:
> >
> > This does look like a decent clean up, especially because so many
> > architectures got this sequence wrong in the past. But yeah, it will
> > require me to rewrite half my series ;-)
> >
> > Is it worth rewriting the series? Dunno. I'm not convinced that the
> > wrapper buys us enough for that,
Oh, I am not sure too. I almost regret I mentioned this cleanup. Just
I was a bit suprised by how many arches do this wrong. See also below.
> plus it'd increase the number of
> patches.
By 1. A single patch can convert the code to use set_current_blocked()
and block_sigmask().
And probably the patch which adds block_sigmask() should change arch/x86
as well, this makes its purpose immediately clear. IOW, I'd prefer the
patch I sent (with rename). But once again, I won't persist.
> > Maybe it'd be better to do it as a separate set of patches?
I don't think so... this means another series touching arch/* to
make the very minor cleanup.
> OK so, I went ahead and rewrote the series using your clean up. It's in
> the 'oleg/set-current-blocked-v2' branch at,
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/linux-2.6.git
>
> Would you mind taking a quick look and see which series you prefer?
No, no, no. Matt, please choose the series which _you_ prefer. You
are the author. I am fine either way.
> I resend any patches.
Yes. I think you should resend the whole series in any case. Because
I think our discussion could confuse the maintainers.
Can I ask you to CC them all in 00/XX ? In this case I can reply
to 00 saying that I am going to take the whole series, unless the
maintainer want to do this. Otherwise I should reply per-arch, this
will certainly cause the confusion.
And, Matt, if I take the patch and then we have any sort of conflict,
you will have to help me with the git problems ;) My understanding
of git magic is quite limited.
Oleg.
next prev parent reply other threads:[~2011-08-18 18:39 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 13:56 [PATCH 00/41] signal: Use set_current_blocked() Matt Fleming
2011-08-11 13:56 ` [PATCH 01/41] alpha: " Matt Fleming
2011-08-11 13:56 ` [PATCH 02/41] arm: " Matt Fleming
2011-08-11 17:04 ` Will Deacon
2011-08-11 13:56 ` [PATCH 03/41] avr32: Don't mask signals in the error path Matt Fleming
2011-08-11 13:56 ` [PATCH 04/41] avr32: use set_current_blocked() in handle_signal/sys_rt_sigreturn Matt Fleming
2011-08-11 13:56 ` [PATCH 05/41] blackfin: Use set_current_blocked() Matt Fleming
2011-08-11 13:56 ` [PATCH 06/41] cris: " Matt Fleming
2011-08-11 13:56 ` [PATCH 07/41] frv: " Matt Fleming
2011-08-11 13:56 ` [PATCH 08/41] h8300: " Matt Fleming
2011-08-11 13:56 ` [PATCH 09/41] ia64: " Matt Fleming
2011-08-11 13:56 ` [PATCH 10/41] m32r: " Matt Fleming
2011-08-11 13:56 ` [PATCH 11/41] m68k: " Matt Fleming
2011-08-11 13:56 ` [PATCH 12/41] microblaze: Don't reimplement force_sigsegv() Matt Fleming
2011-08-16 17:20 ` Oleg Nesterov
2011-08-16 17:20 ` Oleg Nesterov
2011-08-17 13:01 ` Michal Simek
2011-08-17 13:14 ` Oleg Nesterov
2011-08-17 13:25 ` Matt Fleming
2011-08-17 13:17 ` Matt Fleming
2011-08-17 13:22 ` Michal Simek
2011-08-11 13:56 ` [PATCH 13/41] microblaze: No need to reset handler if SA_ONESHOT Matt Fleming
2011-08-11 13:56 ` [PATCH 14/41] microblaze: Fix signal masking Matt Fleming
2011-08-11 13:56 ` [PATCH 15/41] microblaze: Use set_current_blocked() Matt Fleming
2011-08-11 13:56 ` [PATCH 16/41] MIPS: " Matt Fleming
2011-08-11 13:56 ` [PATCH 17/41] mn10300: " Matt Fleming
2011-08-11 13:56 ` [PATCH 18/41] OpenRISC: Don't reimplement force_sigsegv() Matt Fleming
2011-08-16 16:49 ` Oleg Nesterov
2011-08-16 19:33 ` Matt Fleming
2011-08-18 17:47 ` Oleg Nesterov
2011-08-11 13:56 ` [PATCH 19/41] OpenRISC: No need to reset handler if SA_ONESHOT Matt Fleming
2011-08-16 16:53 ` Oleg Nesterov
2011-08-11 13:56 ` [PATCH 20/41] OpenRISC: Don't mask signals if we fail to setup signal stack Matt Fleming
2011-08-11 13:56 ` [PATCH 21/41] OpenRISC: Use set_current_blocked() Matt Fleming
2011-08-11 13:56 ` [PATCH 22/41] parisc: " Matt Fleming
2011-08-11 13:56 ` [PATCH 23/41] powerpc: " Matt Fleming
2011-08-11 13:56 ` [PATCH 24/41] score: Don't mask signals if we fail to setup signal stack Matt Fleming
2011-08-11 13:56 ` [PATCH 25/41] score: Use set_current_blocked() Matt Fleming
2011-08-11 13:57 ` [PATCH 26/41] sh: No need to reset handler if SA_ONESHOT Matt Fleming
2011-08-16 17:25 ` Oleg Nesterov
2011-08-11 13:57 ` [PATCH 27/41] sh: Use set_current_blocked() Matt Fleming
2011-08-11 13:57 ` [PATCH 28/41] sparc: " Matt Fleming
2011-08-11 13:57 ` [PATCH 29/41] tile: " Matt Fleming
2011-08-11 17:10 ` Chris Metcalf
2011-08-11 13:57 ` [PATCH 30/41] um: " Matt Fleming
2011-08-11 13:57 ` [PATCH 31/41] um: Don't restore current->blocked on error Matt Fleming
2011-08-16 17:38 ` Oleg Nesterov
2011-08-11 13:57 ` [PATCH 32/41] unicore32: Use set_current_blocked() Matt Fleming
2011-08-18 8:34 ` Guan Xuetao
2011-08-11 13:57 ` [PATCH 33/41] xtensa: Don't reimplement force_sigsegv() Matt Fleming
2011-08-16 17:40 ` Oleg Nesterov
2011-08-11 13:57 ` [PATCH 34/41] xtensa: No need to reset handler if SA_ONESHOT Matt Fleming
2011-08-11 13:57 ` [PATCH 35/41] xtensa: Don't mask signals if we fail to setup signal stack Matt Fleming
2011-08-11 13:57 ` [PATCH 36/41] xtensa: Use set_current_blocked() Matt Fleming
2011-08-11 13:57 ` [PATCH 37/41] autofs4: " Matt Fleming
2011-08-16 17:47 ` Oleg Nesterov
2011-08-16 20:29 ` Matt Fleming
2011-08-11 13:57 ` [PATCH 38/41] coda: " Matt Fleming
2011-08-11 13:57 ` [PATCH 39/41] dlm: Remove another superfluous call to recalc_sigpending() Matt Fleming
2011-08-11 15:39 ` David Teigland
2011-08-16 19:36 ` Oleg Nesterov
2011-08-11 13:57 ` [PATCH 40/41] ncpfs: Use set_current_blocked() Matt Fleming
2011-08-16 17:56 ` Oleg Nesterov
2011-08-16 20:56 ` Matt Fleming
2011-08-17 12:04 ` Oleg Nesterov
2011-08-17 13:58 ` Matt Fleming
2011-08-17 14:41 ` Oleg Nesterov
[not found] ` <CA+i2_De=mKMHj++b5=ZPdXxp7pm2KzY+PzCaG++GWSud20a_qQ@mail.gmail.com>
2011-08-18 17:05 ` Oleg Nesterov
2011-08-18 20:09 ` Matt Fleming
2011-08-11 13:57 ` [PATCH 41/41] exit: Use __set_task_blocked() Matt Fleming
2011-08-16 18:06 ` Oleg Nesterov
2011-08-16 19:44 ` [PATCH 0/1] kthreads: allow_signal: don't play with ->blocked Oleg Nesterov
2011-08-16 19:44 ` [PATCH 1/1] " Oleg Nesterov
2011-08-16 19:51 ` Tejun Heo
2011-08-16 20:07 ` Oleg Nesterov
2011-08-16 21:50 ` Matt Fleming
2011-08-17 7:27 ` Tejun Heo
2011-08-17 9:56 ` Matt Fleming
2011-08-17 18:26 ` Oleg Nesterov
2011-08-16 21:51 ` [PATCH 41/41] exit: Use __set_task_blocked() Matt Fleming
2011-08-11 16:03 ` [PATCH 00/41] signal: Use set_current_blocked() Oleg Nesterov
2011-08-16 19:40 ` Matt Fleming
2011-08-17 17:01 ` Oleg Nesterov
2011-08-17 22:17 ` Matt Fleming
2011-08-18 11:09 ` Matt Fleming
2011-08-18 18:36 ` Oleg Nesterov [this message]
2011-08-16 19:58 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818183659.GA10353@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.